#25579 closed task (fixed)

Bump snowflake/go-webrtc again for trac 21312

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: snowflake, TorBrowserTeam201803R
Cc: arlolra Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is a followup to #25449.

We discovered additional crashes having to do with the go-webrtc binding in #21312. Although we only saw the crashes in the proxy and server components, not the client, the attached patch applies the same synchronization fixes to the client.

I did a testbuild and put the results here (I'm using it right now to file this ticket):
https://people.torproject.org/~dcf/pt-bundle/snowflake/20180321-8.0a4-4a5889af2891/

Child Tickets

Attachments (1)

0001-Bug-25579-Bump-snowflake-go-webrtc-again-for-trac-21.patch (1.8 KB) - added by dcf 11 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 months ago by dcf

Status: newneeds_review

comment:2 Changed 11 months ago by arlolra

Although we only saw the crashes in the proxy and server components, not the client

This is likely because DefaultSnowflakeCapacity is 1

comment:3 Changed 11 months ago by gk

Keywords: TorBrowserTeam201803R added
Resolution: fixed
Status: needs_reviewclosed

Applied to master (commit 0679737202b5a7343314e0ef7f3aa1fefa5cbd6d), thanks.

Note: See TracTickets for help on using tickets.