Opened 5 months ago

Closed 5 months ago

#25582 closed defect (fixed)

Manual includes non-existant ExitPolicyDefault option

Reported by: atagar Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: fast-fix, 033-included-20180403
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

Back in November I made a few manual fixes which included making its ExitPolicyDefault line visible...

https://gitweb.torproject.org/tor.git/commit/?id=3563a2c

On reflection the tor codebase doesn't look to include any such option. If it wasn't for a torrc option then I'm unsure what ExitPolicyDefault was in reference to...

Most likely we should just drop it from the manual.

Child Tickets

Change History (12)

comment:1 Changed 5 months ago by nickm

Have a look at the state before 3563a2c8194ebe9430603803a53b073e181ce773 -- I think that it was meant to be an anchor only, with no label.

comment:2 Changed 5 months ago by atagar

Gotcha. Is such an anchor useful? I just did a quick grep of webwml but no hits. An anchor seems pretty boot if nothing links to it.

comment:3 Changed 5 months ago by nickm

let's leave the anchor in -- somebody may be using it, and I'd rather not remove anchors once we've added them, unless they're completely pointless.

comment:4 Changed 5 months ago by atagar

Oh! Did a little more looking and it's not there to provide an anchor at all. Rather, it's a hack so the following text is formatted as a paragraph. This is discussed in #20885.

Sure, reverting that line back to an anchor sounds good. Preferably with a comment above that, the SocksPortFlagsMisc, and ORPortFlagsExclusive (if they're still around) to explain that these are formatting hacks rather than intentional anchors.

comment:5 Changed 5 months ago by nickm

Keywords: fast-fix added
Milestone: Tor: 0.3.3.x-final
Owner: set to nickm
Status: newaccepted

comment:6 Changed 5 months ago by nickm

Status: acceptedneeds_review

Fix in bug25582_033

comment:7 Changed 5 months ago by atagar

LGTM, though again I think this (and the other options mentioned above) should be accompanied by a comment saying that they're formatting hacks so it's clear they're not intended to be a torrc option.

comment:8 Changed 5 months ago by dgoulet

Reviewer: dgoulet

Reviewer assignment for week 02/04/2018

comment:9 Changed 5 months ago by nickm

Keywords: 033-included-20180403 added

comment:10 Changed 5 months ago by dgoulet

Status: needs_reviewmerge_ready

To address atagar's comment about having a mention about the formatting hacks, I've added a commit that does that to all options like this one:

See branch: bug25582_033 (based on nickm's from above).

This is ready to merge imo.

comment:11 Changed 5 months ago by atagar

Looks great to me! Thanks David.

comment:12 Changed 5 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged to 0.3.3 and forward!

Note: See TracTickets for help on using tickets.