Opened 21 months ago

Closed 20 months ago

Last modified 20 months ago

#25584 closed defect (worksforme)

The -debug build is broken

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201803, boklm201804
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When running make testbuild-linux-x86_64-debug the build fails in the firefox part.

The logs contain:

Executing /var/tmp/build/firefox-5756f46acaab/obj-x86_64-pc-linux-gnu/dist/bin/shlibsign -v -o ../../dist/firefox/libsoftokn3.chk -i ../../dist/firefox/libsoftokn3.so
Library File: ../../dist/firefox/libsoftokn3.so 2047928 bytes
Check File: ../../dist/firefox/libsoftokn3.chk
  hash: 32 bytes
    78 57 27 a6 7f 68 57 57 f1 2b
    1c c9 17 b3 89 2b 6e e5 76 89
    6f 47 0a d9 ac bd 1c c9 b4 13
    59 68
  signature: 64 bytes
    15 55 ff f3 3f 8c e1 4b 76 47
    01 9e 55 8a 07 63 79 c9 15 e4
    6c 26 79 03 86 a3 66 7a 25 e9
    d5 a3 05 31 ce e3 23 fa 09 3f
    84 6a 99 e5 fd 74 9c 12 ad 01
    f4 b6 e9 86 38 25 c8 71 9b 87
    01 0a 75 1f
ASAN:SIGSEGV
=================================================================
==25788==ERROR: AddressSanitizer: SEGV on unknown address 0x2ab47552d10c (pc 0x2ab4756a98a8 bp 0x00003a45837f sp 0x7ffcd3f07458 T0)
    #0 0x2ab4756a98a7 in __sanitizer::StackDepotBase<__sanitizer::StackDepotNode, 1, 20>::find(__sanitizer::StackDepotNode*, __sanitizer::StackTrace, unsigned int) ../../.././libsanitizer/sanitizer_common/sanitizer_stackdepotbase.h:62
    #1 0x2ab4756a9a38 in __sanitizer::StackDepotBase<__sanitizer::StackDepotNode, 1, 20>::Put(__sanitizer::StackTrace, bool*) ../../.././libsanitizer/sanitizer_common/sanitizer_stackdepotbase.h:104
    #2 0x2ab4756a94e7 in __sanitizer::StackDepotPut(__sanitizer::StackTrace) ../../.././libsanitizer/sanitizer_common/sanitizer_stackdepot.cc:107
    #3 0x2ab4756206b9 in QuarantineChunk ../../.././libsanitizer/asan/asan_allocator2.cc:424
    #4 0x2ab4756206b9 in Deallocate ../../.././libsanitizer/asan/asan_allocator2.cc:462
    #5 0x2ab475692e15 in __interceptor_free ../../.././libsanitizer/asan/asan_malloc_linux.cc:48
    #6 0x2ab4753ed2ab  (/lib64/ld-linux-x86-64.so.2+0x132ab)
    #7 0x2ab4753ed99d  (/lib64/ld-linux-x86-64.so.2+0x1399d)
    #8 0x2ab4753e7ba5  (/lib64/ld-linux-x86-64.so.2+0xdba5)
    #9 0x2ab47678e2eb  (/lib/x86_64-linux-gnu/libdl.so.2+0x12eb)
    #10 0x2ab47678e00e in dlclose (/lib/x86_64-linux-gnu/libdl.so.2+0x100e)
    #11 0x2ab475635ab7 in __interceptor_dlclose ../../.././libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:4638
    #12 0x2ab4754568f0 in pr_LoadLibraryByPathname /var/tmp/build/firefox-5756f46acaab/nsprpub/pr/src/linking/prlink.c:657
    #13 0x2ab4754568f0 in PR_LoadLibraryWithFlags /var/tmp/build/firefox-5756f46acaab/nsprpub/pr/src/linking/prlink.c:418
    #14 0x2ab4753c246f in main /var/tmp/build/firefox-5756f46acaab/security/nss/cmd/shlibsign/shlibsign.c:1323
    #15 0x2ab4769afeac in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x1eeac)
    #16 0x2ab4753c25a0  (/var/tmp/build/firefox-5756f46acaab/obj-x86_64-pc-linux-gnu/security/nss/cmd/shlibsign/shlibsign+0x75a0)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV ../../.././libsanitizer/sanitizer_common/sanitizer_stackdepotbase.h:62 __sanitizer::StackDepotBase<__sanitizer::StackDepotNode, 1, 20>::find(__sanitizer::StackDepotNode*, __sanitizer::StackTrace, unsigned int)
==25788==ABORTING
Traceback (most recent call last):
  File "/var/tmp/build/firefox-5756f46acaab/toolkit/mozapps/installer/packager.py", line 341, in <module>
    main()
  File "/var/tmp/build/firefox-5756f46acaab/toolkit/mozapps/installer/packager.py", line 337, in main
    copier.copy(args.destination)
  File "/var/tmp/build/firefox-5756f46acaab/python/mozbuild/mozpack/copier.py", line 399, in copy
    copy_results.append((destfile, f.copy(destfile, skip_if_older)))
  File "/var/tmp/build/firefox-5756f46acaab/toolkit/mozapps/installer/packager.py", line 124, in copy
    errors.fatal('Error while signing %s' % self.path)
  File "/var/tmp/build/firefox-5756f46acaab/python/mozbuild/mozpack/errors.py", line 103, in fatal
    self._handle(self.FATAL, msg)
  File "/var/tmp/build/firefox-5756f46acaab/python/mozbuild/mozpack/errors.py", line 98, in _handle
    raise ErrorMessage(msg)
mozpack.errors.ErrorMessage: Error: Error while signing ../../dist/firefox/libsoftokn3.so
make[3]: *** [stage-package] Error 1
make[3]: Leaving directory `/var/tmp/build/firefox-5756f46acaab/obj-x86_64-pc-linux-gnu/browser/installer'

Child Tickets

Change History (3)

comment:1 Changed 21 months ago by boklm

The build is working with commit 4e8ca92b2b6424a659f62e9cfdeca3ac107d021c, so it seems the error is caused by the binutils update from #16472.

comment:2 Changed 20 months ago by boklm

Keywords: boklm201804 added; boklm201803 removed

boklm201803 -> boklm201804

comment:3 Changed 20 months ago by gk

Resolution: worksforme
Status: newclosed

We backed out the fix for #16472, so this works for me now. But we should keep it in mind when providing a better fix for #16472.

Last edited 20 months ago by gk (previous) (diff)
Note: See TracTickets for help on using tickets.