#25586 closed defect (fixed)

gethostbyaddr_r doesn't populate h_addrtype field of output hostent struct

Reported by: exarkun Owned by: dgoulet
Priority: Medium Milestone:
Component: Core Tor/Torsocks Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The glibc implementation of gethostbyaddr_r will set h_addrtype to the address family that was passed in as an argument. Some programs depend on this (CPython is the one I noticed) for correct operation.

The current behavior leaves the field unchanged and likely provides an undefined value to the caller. In the case of CPython, this results in socket.gethostbyaddr always raising EAFNOSUPPORT.

Child Tickets

Attachments (1)

torsocks-h_addrtype.patch (2.0 KB) - added by exarkun 21 months ago.
unit tests and bug fix

Download all attachments as: .zip

Change History (3)

Changed 21 months ago by exarkun

Attachment: torsocks-h_addrtype.patch added

unit tests and bug fix

comment:1 Changed 21 months ago by exarkun

Status: newneeds_review

comment:2 Changed 20 months ago by dgoulet

Resolution: fixed
Status: needs_reviewclosed

Thanks!

Commit in a44660bd6d32de6c

Note: See TracTickets for help on using tickets.