Changes between Initial Version and Version 1 of Ticket #25610, comment 9


Ignore:
Timestamp:
Apr 27, 2018, 3:47:33 PM (19 months ago)
Author:
dgoulet
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25610, comment 9

    initial v1  
    44There is very little code "change" per-se that might affect the code behavior. The vast majority is moving code.
    55
    6 The dirauth module is enabled by default so to test this, you'll need to disable it and see how it goes with `--disable-module-dirauth`.
     6The dirauth module is enabled by default so to test this, you'll need to disable it and see how it goes with `--disable-module-dirauth`. The unit tests will *always* build the module.
    77
    8 The unit tests will *always* build the module.
     8This is a milestone, it is not all we can do. There are a couple things that need to happen to fully modularized dirauth and make it also better:
     9
     101. We need to wrap the `authdir_mode()` and cie functions so they NEVER return true if the module is disabled as extra protection.
     11
     122. The `directory.c`, `dirserv.c` and `networkstatus.c` files have a lot of things that are dirauth only. Basically, everything that touches vote document should be extracted into the dirauth module. This is quite a bit of work so we decided to do that as a second step if time permits.
     13
     143. Write a documentation in `doc/HACKING/` probably on how to proceed with a module. It is not that complicated but there are couple things to follow with the build system and code standards.
     15