Opened 6 months ago

Last modified 5 months ago

#25611 new defect

Integ test for MAPADDRESS

Reported by: atagar Owned by: atagar
Priority: Low Milestone:
Component: Core Tor/Stem Version:
Severity: Minor Keywords: testing
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Stem had an integration test for tor's MAPADDRESS command...

https://gitweb.torproject.org/stem.git/tree/test/integ/control/controller.py#n1120

However, it doesn't work...

======================================================================
FAIL: test_mapaddress
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/atagar/Desktop/stem/test/require.py", line 58, in wrapped
    return func(self, *args, **kwargs)
  File "/home/atagar/Desktop/stem/test/require.py", line 58, in wrapped
    return func(self, *args, **kwargs)
  File "/home/atagar/Desktop/stem/test/integ/control/controller.py", line 1154, in test_mapaddress
    self.assertTrue(stem.util.connection.is_valid_ipv4_address(stem.util.str_tools._to_unicode(ip_addr)), "'%s' isn't an address" % ip_addr)
AssertionError: '<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>403 Forbidden</title>
</head><body>
<h1>Forbidden</h1>
<p>You don't have permission to access /ip
on this server.</p>
</body></html>' isn't an address

After several hours of fiddling with it I'm disabling the failing test for now. Things I checked were...

  • Tested with both the current stem codebase and last release tag (1.6.0) to rule out a recent regression in stem.
  • Tested with both the current tor git codebase and an older version (0.2.7.6) to rule out a regression in tor.
  • Through tor browser visited the site this test retrieves (http://ifconfig.me/ip) in case they're blocking tor. No dice.

Open questions are 'why did this test start failing?' and get integ coverage for MAPADDRESS. Happy to outright replace this test with something else that exercises it.

Child Tickets

Change History (1)

comment:1 Changed 5 months ago by atagar

Keywords: testing added
Note: See TracTickets for help on using tickets.