unable to resolve DNS requests from control port, regression

setevents addrmap
250 OK

resolve blog.torproject.org
250 OK
650 ADDRMAP blog.torproject.org <error> "2018-03-25 08:39:54" error=yes EXPIRES="2018-03-25 12:39:54" CACHED="NO"

Mar 25 08:39:55 Tor[]: Refusing to connect to hostname [scrubbed] because Port has NoDNSRequest set.

changed milestone to %Tor: 0.3.3.x-final

added 029-backport 031-backport 032-backport 033-must component::core tor/tor milestone::Tor: 0.3.3.x-final owner::nickm priority::medium regression resolution::fixed reviewer::dgoulet severity::normal status::closed tor-control tor-dns type::defect version::tor 0.2.9.3-alpha labels

I can confirm that the above sequence happens as described -- in master and in maint-0.2.9.

You say regression -- can you remind us when this used to work? :)

er, not sure. . .2.6.something?

Seems to me client DNS was extensively renovated along the way with an eye toward IPv6. SocksPort flag NoDNSRequest is new and related I think. Perhaps +DNSRequest or -NoDNSRequest applied invisibly to control ports would fix?

Possible regression thus marking it for proposed inclusion in 033.

Trac:
Milestone: N/A to Tor: 0.3.3.x-final
Keywords: N/A deleted, tor-control, 033-must, tor-dns, regression added

Looks like that feature went into 0.2.9.3-alpha, as part of #18693 (moved).

Looks like the fix should go in dnsserv_launch_request() down when we're messing with entry_conn->entry_cfg.

This is a one-line fix fwict

Trac:
Status: new to accepted
Owner: N/A to nickm

bug25617_029 is a fix here; it works fine for me.

Trac:
Keywords: N/A deleted, 029-backport 031-backport 032-backport added
Status: accepted to needs_review

Also works for me!

RESOLVE test.com
250 OK
650 ADDRMAP test.com 69.172.200.235 "2018-03-29 11:23:34" EXPIRES="2018-03-29 15:23:34" CACHED="

Trac:
Status: needs_review to merge_ready
Reviewer: N/A to dgoulet

I think for this one we could happily put the fix into 0.3.3 and not do backports. It is indeed broken in earlier versions, but it has been for a long time, and this is the first we noticed, and also it's kind of an 'expert' feature.

Merged to 0.3.3. Not marking for backport, per my inclination and Roger's recommendation.

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

This was broken in 0.2.9.3-alpha,

Trac:
Version: Tor: 0.3.3.3-alpha to Tor: 0.2.9.3-alpha

closed

mentioned in issue #25919 (moved)

moved to tpo/core/tor#25617 (closed)