Opened 5 months ago

Closed 5 months ago

#25629 closed defect (fixed)

fix CID 1430932

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 033-must regression 029-backport 031-backport 032-backport 033-triage-20180326 033-included-20180326
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by catalyst)

Coverity found a null pointer reference in nodelist_add_microdesc().
This is almost certainly impossible assuming that the routerstatus_t
returned by router_get_consensus_status_by_descriptor_digest() always
corresponds to an entry in the nodelist.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by nickm

Keywords: 033-must regression 029-backport 031-backport 032-backport 033-triage-20180326 033-included-20180326 added

comment:2 Changed 5 months ago by catalyst

Description: modified (diff)
Status: assignedneeds_review

Added description. Pull requests with patches:

0.2.9 and 0.3.1: https://github.com/torproject/tor/pull/30

0.3.2: https://github.com/torproject/tor/pull/31

0.3.3 and master: https://github.com/torproject/tor/pull/32

0.2.9 merges cleanly to 0.3.1; 0.3.3 merges cleanly to master.

comment:3 Changed 5 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

whoa. Thanks, Taylor -- that was more branches than I thought it would be, but they all look fine!

Merging to appropriate targets and closing.

Note: See TracTickets for help on using tickets.