Opened 12 months ago

Last modified 4 months ago

#25651 assigned enhancement

Handle incoming extend2/extended2 fragmented requests/replies. (prop249)

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-cell, tor-circuit, trunnel, 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328, 035-roadmap-subtask, 035-triaged-in-20180711
Cc: dgoulet, isis, nickm, dmr Actual Points:
Parent ID: #24986 Points: 3
Reviewer: Sponsor: SponsorM-can

Description

As part of prop249, we need to handle large create cells when they arrive fragmented across multiple extend cells (and similarly for created cells fragmented across multiple extended cells).

Important notes:

  • The proposal says that there must be no intervening cells on the same circuit. We should enforce this and test it.
  • We should probably use a buf_t object to record these handshakes as they are being assembled.
  • We should count these handshakes against the memory usage of a circuit and age of the oldest queued data, so that they will participate correctly in the OOM system.

Child Tickets

TicketTypeStatusOwnerSummary
#25657enhancementnewprop249: make sure that we incorporate fragmented extend[ed]2 cells in our OOM code

Change History (10)

comment:1 Changed 12 months ago by nickm

Keywords: 034-roadmap-subtask added

comment:2 Changed 12 months ago by nickm

Keywords: 034-triage-20180328 added

comment:3 Changed 12 months ago by nickm

Keywords: 034-included-20180328 added

comment:4 Changed 11 months ago by isis

Owner: set to isis
Points: 3
Sponsor: SponsorM-can
Status: newaccepted
Type: defectenhancement

comment:5 Changed 11 months ago by isis

Milestone: Tor: 0.3.4.x-finalTor: 0.3.5.x-final

I've made progress on this in my bug25651 WIP branch, but there's not much point trying to rush this into 034, since a bunch of the other #24986 child tickets have been deferred to 035.

comment:6 Changed 9 months ago by nickm

Keywords: 035-roadmap-subtask added

comment:7 Changed 9 months ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:8 Changed 8 months ago by dmr

Cc: dmr added

comment:9 Changed 7 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: unspecified

We won't get PQ or wide-create done in this release. :/

comment:10 Changed 4 months ago by gaba

Owner: isis deleted
Status: acceptedassigned
Note: See TracTickets for help on using tickets.