Changes between Initial Version and Version 1 of Ticket #25658, comment 88


Ignore:
Timestamp:
Mar 12, 2019, 6:38:14 PM (4 months ago)
Author:
pospeselr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25658, comment 88

    initial v1  
    886. Yeah I *believe* the version you have doesn't have my toolbar changes. A clean build (on Linux) has NoScript and HTTPS-Everywhere removed, will have to look into the torbutton issue. #23359 will need to be fixed before the icons work correctly.
    997. This behaviour is expected as there isn't any upgrade logic in place. How is this sort of thing usually handled?
     10
     11EDIT:
     12
     13> 2. Should we rename the `security_slider` pref and migrate the old value at this time, or later, or never? Maybe use the name `torbrowser.security_level` and migrate to contiguous values (1-3).
     14I initially had the same thought about renaming prefs, but I would prefer to do so in a future smaller patch where we can excise all the associated logic from torbuton as well as do a name change.
     15
     16I'll try and get these changes amended asap.