Opened 9 years ago

Closed 9 years ago

#2566 closed defect (fixed)

Set UseEntryGuards=1 in entrycons.py

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone:
Component: Metrics/CollecTor Version:
Severity: Keywords:
Cc: Actual Points: 1
Parent ID: Points: 1
Reviewer: Sponsor:

Description

Torperfs that were piggybacked with entrycons.py to select their guards were still disabling guard nodes with UseEntryNodes 1.

Child Tickets

Change History (9)

comment:1 Changed 9 years ago by mikeperry

Resolution: fixed
Status: newclosed

This fix and the script that found the issue are in mikeperry/bug2566 for torperf's git.

comment:2 Changed 9 years ago by mikeperry

Points: 1
Resolution: fixed
Status: closedreopened

comment:3 Changed 9 years ago by mikeperry

Owner: changed from 1 to mikeperry
Status: reopenedassigned

comment:4 Changed 9 years ago by mikeperry

Resolution: fixed
Status: assignedclosed

I love you too, trac.

comment:5 Changed 9 years ago by karsten

Resolution: fixed
Status: closedreopened

Not so fast. We should merge your fix, plus the fact that we were not redirecting stderr. See branch bug2566 in my public repository which is based on yours.

comment:6 Changed 9 years ago by karsten

Status: reopenedneeds_review

comment:7 Changed 9 years ago by Sebastian

I'm not sure I like

-  conn.set_option("StrictEntryNodes", "1")
+  conn.set_option("UseEntryNodes", "1")
+  conn.set_option("StrictNodes", "1")

unless we are extra sure we don't want to run torperfs on 0.2.1.x tors

comment:8 Changed 9 years ago by karsten

Sebastian says that 0.2.2.x will work just fine with StrictEntryNodes. So let's undo that change, so that we can support 0.2.1.x, too. But let's keep UseEntryNodes 1 in, because it does no harm.

comment:9 Changed 9 years ago by Sebastian

Resolution: fixed
Status: needs_reviewclosed

Thanks, merged with my suggested fix.

Note: See TracTickets for help on using tickets.