Opened 2 years ago

Closed 2 years ago

#25664 closed defect (implemented)

Update libc version requirement in and

Reported by: gk Owned by:
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust, tor-doc, 033-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

When merging the patches for #25310 the libc version requirement in and did not get updated.

Child Tickets

Attachments (1)

0001-Bug-25664-Update-libc-version-requirement-for-Rust.patch (1.3 KB) - added by gk 2 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 2 years ago by gk

Status: newneeds_review

The attached patch has the small fix for this bug.

comment:2 Changed 2 years ago by gk

Actually, it seems #25310 forgot an additional thing. There is

dnl List all external rust crates we depend on here. Include the version

in It seems we need to bump the version there as well as otherwise one would be in the weird situation of having the required 0.2.39 available but configure complaining about the missing 0.2.22.

EDIT: well, it won't complain about missing dependencies which is why my tor build failed during the build and not configure stage before I updated the submodule. Still, checking on master for 0.2.22 and not 0.2.39 is wrong after #25310 landed.

Last edited 2 years ago by gk (previous) (diff)

comment:3 Changed 2 years ago by gk

Description: modified (diff)
Status: needs_reviewneeds_revision
Summary: Update libc version requirement in GettingStartedRust.mdUpdate libc version requirement in and

comment:4 Changed 2 years ago by gk

Status: needs_revisionneeds_review

Added an updated patch.

comment:5 Changed 2 years ago by teor

Keywords: 033-backport added
Status: needs_reviewmerge_ready

Thanks for this patch!

#25310 was merged to 0.3.3, so this change also needs to be backported to 0.3.3.

This change will also need a changes file, and an update to the tor-rust-dependencies repository. I think nickm can do those when he merges.

comment:6 Changed 2 years ago by nickm

I'm adding the changes file, but I believe that tor-rust-dependencies is already updated.

comment:7 Changed 2 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

added; merged. thanks!

Note: See TracTickets for help on using tickets.