Changes between Initial Version and Version 1 of Ticket #25688, comment 12


Ignore:
Timestamp:
Mar 30, 2019, 4:38:08 PM (10 months ago)
Author:
cohosh
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25688, comment 12

    initial v1  
    22
    33It's safer to only write to answerChan after we're sure that dataChannelHandler (which calls retToken() on return) has been called.
     4{{{
     5go datachannelHandler(conn, conn.RemoteAddr())
     6answerChan <- struct{}{}
     7}}}
    48
    59It's also worth pointing out that apparently OnICECompletel is being deprecated ([https://github.com/keroserene/go-webrtc/blob/master/peerconnection.go#L518, peerconnection.go#L518]) we are better off not relying on it anyway.
    610
    7 I'm going to run this modified version as a proxy-go instance for a few days to see if it deadlocks before putting this in merge_ready.
     11I'm going to run this modified version as a proxy-go instance for a few days to see if it deadlocks.