Changes between Version 1 and Version 2 of Ticket #25705, comment 2


Ignore:
Timestamp:
Apr 4, 2018, 4:13:19 PM (4 months ago)
Author:
asn
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25705, comment 2

    v1 v2  
    1616- Do we want to mark the guard as bad for any `DESTROY` reason? Is there a reason we wouldn't do that? Do we remember our old rationale here. Seems like the commit that introduced the ''don't do anything if DESTROY'' logic is  Roger in `5de88dda0acda6914bacd1e14c2e037798c5d9d9`.
    1717
    18 - Do we want to merge this patch without taking the precautions of Roger's points `G` and `E` from #25347?
     18- Do we want to merge this patch without taking the precautions of Roger's points `G` and `E` from #25347? I have strong hesitation about the behavior of this commit given Roger's point G. Also see comment:31:ticket:25347.
    1919
    2020- The code needed a parenthesis to compile. We should test this new code, it seems ultra crucial!