Opened 5 months ago

Closed 5 months ago

#25714 closed task (implemented)

switch Travis to using Rust stable

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ci, rust, fast-fix
Cc: isis Actual Points:
Parent ID: #25550 Points:
Reviewer: Sponsor: Sponsor3

Description

Right now our Travis use Rust nightly instead of stable. Now that we are standardizing on a stable Rust (see #24765), we should have Travis use stable so we catch accidental uses of nightly features.

Child Tickets

Change History (5)

comment:1 Changed 5 months ago by catalyst

Keywords: fast-fix added
Owner: set to catalyst
Status: newassigned

comment:2 Changed 5 months ago by catalyst

Status: assignedneeds_review

Patch in https://github.com/torproject/tor/pull/39

Do we want to backport this?

comment:3 Changed 5 months ago by nickm

Cc: isis added

Backporting seems fine to me: it only affects travis builds, not actual stability.

Adding isis to cc for a second opinion, but this looks fine to me.

comment:4 in reply to:  3 Changed 5 months ago by isis

Replying to nickm:

Backporting seems fine to me: it only affects travis builds, not actual stability.

Adding isis to cc for a second opinion, but this looks fine to me.


Backporting sounds good to me; we want our tests testing what we actually expect to work. :)

comment:5 Changed 5 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Okay; cherry-picked to 0.3.1 and merged forward.

Note: See TracTickets for help on using tickets.