Add bool types to Rust coding standards guidelines

Similar to #25368 (moved), we can once again expand upon which Rust types are safe to send over the FFI boundary without conversion/serialisation/translation, because Rust's bool type and C99's bool type are directly compatible. (I think this also makes an even larger argument moving forward for using bools in C wherever it makes sense, since otherwise we need to convert between the libc uint8_t type and the native u8 in Rust.)

changed milestone to %Tor: unspecified

added 035-triaged-in-20180711 component::core tor/tor fast-fix milestone::Tor: unspecified owner::catalyst points::.1 priority::medium resolution::wontfix reviewer::catalyst rust severity::normal sponsor::M-can status::closed torspec type::enhancement labels

Done in my bug25727 branch.

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to catalyst

Summarizing yesterday's IRC discussion:

• Rust has debated whether Rust's bool is identical to C99's _Bool for a while.
• Rust now specifies that its bool is one byte.
• There is a postponed RFC to define Rust's bool and C99's _Bool to be FFI-compatible. We should either postpone merging this until Rust decides to accept RFC 954 or point to that RFC (and maybe the follow up RFC 992) in our doc. There seems to be a consensus that it should be accepted but it seems they haven't gone through the formalities yet.

This patch also adds a non-ASCII character in a file that previously had none. I think we lack a style guide that covers the acceptability of non-ASCII in various files, but this is a change. On the other hand CodingStandardsRust.md already had some non-ASCII characters in it so maybe we don't actually care that much?

Trac:
Status: needs_review to needs_revision

I've left a comment on Rust RFC 992 here.

Move most needs_revision tickets from 0.3.4 to 0.3.5: we're about to hit the feature freeze.

If you really need to get this into 0.3.4, please drop me a line. :)

Trac:
Milestone: Tor: 0.3.4.x-final to Tor: 0.3.5.x-final

Trac:
Keywords: N/A deleted, 035-triaged-in-20180711 added

I left a comment on the RFC here back in May but haven't received a reply yet.

We won't get PQ or wide-create done in this release. :/

Trac:
Milestone: Tor: 0.3.5.x-final to Tor: unspecified

Trac:
Status: needs_revision to assigned
Owner: isis to catalyst

Unfortunately, it seems like Rust RFC 992 was closed without taking the final step of explicitly documenting the ABI equivalence of Rust's bool and C's _Bool. Further comments from a Rust core team member imply that this is unlikely to be resolved any time soon.

Trac:
Resolution: N/A to wontfix
Status: assigned to closed

closed

changed time estimate to 48m

moved to tpo/core/tor#25727 (closed)