Opened 2 years ago

Closed 2 years ago

#25757 closed enhancement (fixed)

Allow offline integ tests to be run in a no-network/firewalled state

Reported by: dmr Owned by: dmr
Priority: Low Milestone:
Component: Archived/Stem Version:
Severity: Minor Keywords:
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: atagar Sponsor:

Description

Stem's integration tests are run by e.g. run_tests.py --all or tox, and by default do not include the ONLINE target. (See run_tests.py --help for more info on running ONLINE tests.)

These remaining integration tests should be runnable offline; however, it appears that they require the tor process to bootstrap to 5% in order to run.
Waiting for 5% was introduced in commit fbfa73a099d9645f18d9846420cbf0145065b11d from 2011.

Empirically, I switched this to 0% and all these integ tests still worked fine.

In chatting with atagar over IRC, he wasn't aware of a reason offhand for waiting for 5%, and suggested we could change this since the tests still pass.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by dmr

Status: assignedneeds_review

Please find a patch for this at:
git@github.com:dmr-x/stem.git branch 25757-offline-integ-tests commit e13600612a722b0d3dd6ffc32e5965ed35acdfae

web links:
​​https://github.com/dmr-x/stem/tree/25757-offline-integ-tests
https://github.com/dmr-x/stem/commit/e13600612a722b0d3dd6ffc32e5965ed35acdfae

I've tested the patch by using ufw and a deny-outbound firewall.
All integ tests run by tox -e py27,py35 pass.

comment:2 Changed 2 years ago by atagar

Resolution: fixed
Status: needs_reviewclosed

Wee! Fun seeing a commit from that far back. Really from the primordial days of stem. :P

Tests are happy for me too. Pushed - thanks for the fix!

Note: See TracTickets for help on using tickets.