Opened 19 months ago

Closed 19 months ago

#25766 closed defect (implemented)

Refactor token buckets to meet current coding standards

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328
Cc: Actual Points:
Parent ID: #25373 Points:
Reviewer: dgoulet Sponsor: Sponsor8-can

Description

Our existing token bucket code is a mess. We should clean it up before we tackle #25373.

Child Tickets

Change History (6)

comment:1 Changed 19 months ago by nickm

Reviewer: → dgoulet
Status: assigned → needs_review

Current branch is token_bucket_refactor.

comment:2 Changed 19 months ago by nickm

(This branch is based on the remove_tb_empty branch of #25760.)

comment:3 Changed 19 months ago by nickm

​https://github.com/torproject/tor/pull/46 is a github pull request.

comment:4 Changed 19 months ago by nickm

I've responded to dgoulet's review of the initial PR.

comment:5 Changed 19 months ago by nickm

I had to make some additional changes there, since it turns out my initial approach wouldn't compile on OSX.

comment:6 Changed 19 months ago by nickm

Resolution: → implemented
Status: needs_review → closed

squashed and merged to master, per discussion on ticket.

Note: See TracTickets for help on using tickets.