Opened 3 years ago

Closed 3 years ago

#25767 closed enhancement (fixed)

consensus-health should check for clock skew on dir auths

Reported by: arma Owned by: tom
Priority: Medium Milestone:
Component: Metrics/Consensus Health Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In #25756 we discovered that it can actually produce a user-visible complaint when dizum has its clock wrong by 65 seconds.

Specifically, when the combination of skew from the dir auth and from the relay doing the fetch sum to more than 60 seconds, then if the relay decides to update its consensus at just the right time, the relay will get a warn message.

It would be great if consensus-health checked the Date: header on dir auth responses, and did something smart if it's not right enough.

Note that the Date header gets chosen when the dir auth begins to respond to the request, so if it takes 25 seconds to finish downloading the request, you shouldn't decide that the Date was wrong by 25 seconds.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by arma

Also note that I filed nearly the same ticket for doctor in #25768 -- I wonder if there is some better way to handle overlapping functionality in the future.

Note: See TracTickets for help on using tickets.