Opened 7 months ago

Closed 4 months ago

Last modified 4 months ago

#25782 closed defect (fixed)

Bump stem for depictor

Reported by: tom Owned by: tom
Priority: Medium Milestone:
Component: Metrics/Consensus Health Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

11:10:15 A<+atagar> tjr: You'll find that depictor will have timeouts too when you update Stem. Stem now drops the '.z' suffix and replaces it with an Accept-Encoding header...
11:10:18 A<+atagar> https://gitweb.torproject.org/stem.git/commit/?id=079b481
11:10:38 A<+atagar> To cut down on noise DocTor no longer downloads from tor26.
11:11:00 T<+tjr> Hm... I don't think that's going to be an option for me...
11:11:26 A<+atagar> Why?
11:11:56 A<+atagar> I did a similar thing for turtles back in the day. Certainly understandable though if it's a no-go. :)
11:12:04 A<+atagar> I suppose we might be able to hack around it.
11:12:36 T<+tjr> Well, I suppose I could get the vote from another DirAuth.  But not downloading would mean they would fall off (or have bad data) for the download times table
11:12:46 T<+tjr> Not that that table is terribly accurate today but....
11:13:18 A<+atagar> Gotcha. For DocTor the hack I did was to simply stop treating tor26 as a dirauth.
11:13:44 A<+atagar> Ah, I've got an idea.
11:14:17 A<+atagar> The DescriptorDownloader should return you a query object. You can overwrite the resource attribute to add back the '.z' before making the request.
11:14:45 A<+atagar> Since the stripping happens in the constructor...
11:14:46 A<+atagar> https://gitweb.torproject.org/stem.git/tree/stem/descriptor/remote.py#n370
11:16:01 A<+atagar> Note that you'll want to include 'start = False' in your call so the request isn't made until you change the resource.

Child Tickets

Change History (1)

comment:1 Changed 4 months ago by tom

Resolution: fixed
Status: newclosed

I believe this is fixed now and i bumped

Note: See TracTickets for help on using tickets.