geoip_load_file() tests don't work on all window build environments

These tests assume that when the test binary is run, it can see the contents of the builddir at the same location as the original build process. But that isn't always true for windows builds.

changed milestone to %Tor: 0.3.4.x-final

added 034-must component::core tor/tor milestone::Tor: 0.3.4.x-final owner::nickm priority::medium regression resolution::fixed reviewer::dgoulet severity::normal status::closed tests type::defect win32 labels

I've added a temporary fix as 8eb4a32a4dc4e9ecccb162a70b5212a9a2d3f80c , but we should come up with a better one.

Trac:
Keywords: 043-must regression tests win32 deleted, 034-must regression tests win32 added

Trac:
Status: new to accepted
Owner: N/A to nickm

Please see branch bug25787 with PR at https://github.com/torproject/tor/pull/143 .

The fix here IMO is to just cut the Gordian Knot and generate the files we need ourself rather than trying at build-time to generate paths that Windows tests at run-time will accept.

cc'ing juga because juga has seen these tests since the beginning, and ought to see it when we admit failure :)

Trac:
Cc: N/A to juga
Status: accepted to needs_review

clang (from travis) doesn't seem very happy with the PR :S ... https://travis-ci.org/torproject/tor/jobs/390995401

src/test/test_geoip.c:386:12: error: no previous extern declaration for
      non-static variable 'GEOIP_CONTENT'
      [-Werror,-Wmissing-variable-declarations]
const char GEOIP_CONTENT[] =

Trac:
Status: needs_review to needs_revision

I think I fixed that with the fixup commit, though?

Trac:
Status: needs_revision to needs_review

lgtm;

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to merge_ready

Merged to 0.3.4 and forward!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

mentioned in issue #26479 (moved)

moved to tpo/core/tor#25787 (closed)