#25790 closed defect (fixed)

Orfox lists external apps when the user clicks and holds an Android URI in a WebPage

Reported by: igt0 Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201807R
Cc: sysrqb, gk Actual Points:
Parent ID: #25703 Points:
Reviewer: Sponsor:

Description

Even if the network.protocol-handler.external-default is false an user can open an external application.

When an user clicks and holds an Android URI[1] the browser context menu opens and if the android has an app with the same package id in the URI, the app is listed in the context menu allowing the user to click on it and open an external app.

[1] http://mcomella.xyz/test/uri.html

Child Tickets

Change History (10)

comment:1 Changed 19 months ago by igt0

Parent ID: #25703

Add #25703 as parent ticket since an intent can send information to an external app and leak user information.

comment:2 Changed 18 months ago by igt0

Cc: sysrqb gk added

comment:3 Changed 18 months ago by igt0

Mozilla bug used to track this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1455165

comment:5 Changed 18 months ago by gk

Nice! It seems we are good for the first alpha then as this one will likely be based on Firefox 61? If so, let's close this ticket.

comment:6 in reply to:  5 Changed 18 months ago by igt0

Resolution: fixed
Status: assignedclosed

Yep, we plan to use FF 61.

Replying to gk:

Nice! It seems we are good for the first alpha then as this one will likely be based on Firefox 61? If so, let's close this ticket.

comment:7 Changed 16 months ago by igt0

Resolution: fixed
Status: closedreopened

Since we are going to use FF60, we need to cherry pick this patch.

comment:8 Changed 15 months ago by gk

Keywords: TorBrowserTeam201807R added
Status: reopenedneeds_review

comment:9 Changed 15 months ago by igt0

I tested it and looks good. LGTM

comment:10 Changed 15 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed with commit 3d30d5d1f2ebbdf60af0180af435afad4ba7e773 on tor-browser-60.1.0esr-8.0-1.

Note: See TracTickets for help on using tickets.