Opened 14 months ago

Closed 8 months ago

#25796 closed enhancement (fixed)

Update spec.torproject.org for new specs

Reported by: teor Owned by: tpa
Priority: Medium Milestone: Tor: unspecified
Component: Internal Services/Tor Sysadmin Team Version:
Severity: Normal Keywords: tor-spec, easy, doc
Cc: mtigas Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There are 4 new specs, and one has moved.
It would also be nice to map proposals/

Is this an automated process, or does it need a manual patch?

Child Tickets

Change History (13)

comment:1 Changed 14 months ago by weasel

Resolution: invalid
Status: newclosed

Unclear what this ticket is asking.

comment:2 Changed 14 months ago by teor

Resolution: invalid
Status: closedreopened

https://spec.torproject.org lists 15 specs.
The rend-spec link is broken: https://gitweb.torproject.org/torspec.git/tree/rend-spec.txt
There are four new specs on https://gitweb.torproject.org/torspec.git/tree/

Is there an automated tool to update spec.torproject.org, or does someone need to submit a patch?

The footer on https://spec.torproject.org says:

For additions, please ask weasel (or some other admin) to apply your patch to tor-puppet/modules/roles/files/spec/spec-redirects.yaml.

comment:3 Changed 14 months ago by arma

weasel, it's not nice or appropriate to close tickets like this without some clearer explanation of what has gone wrong.

In this case, "please make a diff" is one good answer.

Speaking of which, *is* there a better component than this one, for tor-puppet changes? I think no?

Does that mean we want to make a separate puppet subcomponent? Or should we accept tickets on this component?

comment:4 Changed 14 months ago by weasel

Owner: changed from tpa to nobody
Status: reopenedassigned

in the meantime, this ticket is still not actionable.

comment:5 Changed 14 months ago by weasel

Status: assignedneeds_information

comment:6 Changed 14 months ago by weasel

Resolution: user disappeared
Status: needs_informationclosed

Please create a new ticket when there's something to do.

comment:7 Changed 14 months ago by teor

Component: Internal Services/Tor Sysadmin TeamCore Tor/Tor
Keywords: tor-spec easy doc added
Milestone: Tor: unspecified
Resolution: user disappeared
Status: closedreopened

I would like to keep this ticket open, so we remember to do it.

Since these are tor specs, I am assigning it to the core tor component.

comment:8 Changed 14 months ago by teor

Owner: nobody deleted
Status: reopenedassigned

comment:9 Changed 11 months ago by teor

Status: assignednew

Make everything that is assigned to no-one new again.

comment:10 Changed 8 months ago by mtigas

Couldn't upload patch to trac ("Maximum number of external links per post exceeded"), but here's a patch that updates the list with everything in torspec.git:

https://gist.githubusercontent.com/mtigas/49c40da7d9e65bd69310d84c3fd89149/raw/fd75f1e34c2a002278d2854936845f91240a645e/spec-redirects.yaml.patch

comment:11 Changed 8 months ago by mtigas

Cc: mtigas added

comment:12 Changed 8 months ago by teor

Component: Core Tor/TorInternal Services/Tor Sysadmin Team
Owner: set to tpa
Status: newmerge_ready

Thanks for this patch!

I tweaked it to avoid breaking the "rend-spec" link.

Over to the sysadmin team for merge.

--- spec-redirects.yaml.orig	2018-10-12 17:03:10.000000000 -0400
+++ spec-redirects.yaml	2018-10-15 02:00:00.000000000 +0000
@@ -3,6 +3,9 @@
   'address-spec':
     target: https://gitweb.torproject.org/torspec.git/tree/address-spec.txt
     description: Special Hostnames in Tor
+  'bandwidth-file-spec':
+    target: https://gitweb.torproject.org/torspec.git/tree/bandwidth-file-spec.txt
+    description: Directory Authority Bandwidth File spec
   'bridgedb-spec':
     target: https://gitweb.torproject.org/torspec.git/tree/bridgedb-spec.txt
     description: BridgeDB specification
@@ -15,18 +18,27 @@
   'dir-spec':
     target: https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt
     description: Tor directory protocol, version 3
+  'dir-list-spec':
+    target: https://gitweb.torproject.org/torspec.git/tree/dir-list-spec.txt
+    description: Tor Directory List file format
   'gettor-spec':
     target: https://gitweb.torproject.org/torspec.git/tree/gettor-spec.txt
     description: GetTor specification
+  'padding-spec':
+    target: https://gitweb.torproject.org/torspec.git/tree/padding-spec.txt
+    descriptio : Tor Padding Specification
   'path-spec':
     target: https://gitweb.torproject.org/torspec.git/tree/path-spec.txt
     descriptio : Tor Path Specification
   'pt-spec':
     target: https://gitweb.torproject.org/torspec.git/tree/pt-spec.txt
     description: Tor Pluggable Transport Specification, version 1
   'rend-spec':
     target: https://gitweb.torproject.org/torspec.git/tree/rend-spec-v2.txt
-    description: Tor Rendezvous Specification
+    description: Tor Onion Service Rendezvous Specification, Version 2
+  'rend-spec-v2':
+    target: https://gitweb.torproject.org/torspec.git/tree/rend-spec-v2.txt
+    description: Tor Onion Service Rendezvous Specification, Version 2
+  'rend-spec-v3':
+    target: https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt
+    description: Tor Onion Service Rendezvous Specification, Version 3
   'socks-extensions':
     target: https://gitweb.torproject.org/torspec.git/tree/socks-extensions.txt
     description: "Tor's extensions to the SOCKS protocol"

comment:13 Changed 8 months ago by weasel

Resolution: fixed
Status: merge_readyclosed

The patch didn't apply (patch: malformed patch at line 42: 'socks-extensions':), so I merged it manually.

Thanks!

Note: See TracTickets for help on using tickets.