#25814 closed defect (implemented)

Should Travis use "make distcheck"?

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ci, 034-roadmap-subtask
Cc: isis, catalyst Actual Points:
Parent ID: #25550 Points:
Reviewer: isis Sponsor:

Description

I just noticed that we had broken "make dist" on master, because one of the jenkins builders wasn't passing. I fixed it with 197d1992dba2fe.

Should our Travis builds be reconfigured to use "make distcheck" instead of "make all && make check"? It takes only a little bit longer, but it would help us be sure that we weren't running into any issues like the one above, or #25732.

Instead of passing things to "configure" directly in this case, we would need to use the DISTCHECK_CONFIGURE_FLAGS flag to set the configuration options that distcheck would use.

Child Tickets

Change History (7)

comment:1 Changed 17 months ago by nickm

Keywords: 034-roadmap-subtask added; 034-roadmap-master 034-triage-20180328 034-included-20180328 removed

comment:2 Changed 17 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:3 Changed 17 months ago by nickm

Status: acceptedneeds_review

I have a patch here in a branch called travis_distcheck_029.

We should also make sure that the distributed bundles work with Rust, and I have a branch for that as travis_distcheck_031. However, we shouldn't merge that branch into 0.3.1: "make distcheck" doesn't work with Rust until 0.3.3! I have merged that branch forward as travis_distcheck_033.

comment:4 Changed 17 months ago by nickm

Cc: isis catalyst added

comment:5 Changed 17 months ago by isis

Reviewer: isis
Status: needs_reviewmerge_ready

I'm sorry, I noticed the Rust breakage with 0.3.1 and 0.3.2 because I build .debs for my Qubes sys-tor VM, but I never said anything because I don't (want to) understand enough^Wmore about Debian or its packaging system(s) and didn't really want to get into it. In retrospect, I probably should have filed a ticket.

This patch LGTM!

Maybe we want to have conversations at some point about what Jenkins' function/purpose is (I thought it existed specifically to test packaging and more diverse architectures and platforms like arm and win32), and who maintains our Debian stuff (we seem to do a lot of bending over backwards specifically for Debian when there's also other good distros whom we completely ignore)? If so, maybe we should schedule these conversations for the Seattle 2018 network-team meeting?

comment:6 in reply to:  5 Changed 17 months ago by nickm

Replying to isis:

I'm sorry, I noticed the Rust breakage with 0.3.1 and 0.3.2 because I build .debs for my Qubes sys-tor VM, but I never said anything because I don't (want to) understand enough^Wmore about Debian or its packaging system(s) and didn't really want to get into it. In retrospect, I probably should have filed a ticket.

This patch LGTM!

Great! I'll plan to merge it once the team has had a chance to discuss the issue below. Let's either do it at monday meeting, or schedule a time then to do it later.

Maybe we want to have conversations at some point about what Jenkins' function/purpose is (I thought it existed specifically to test packaging and more diverse architectures and platforms like arm and win32),

From my point of view, it's okay if we rely on Jenkins to test packaging and diverse architectures, but only if we are looking at it and fixing the issues. On the other hand, if we don't treat bugs found by Jenkins failures as "must fix", then I think we need to take more patches like this that add more configurations to Travis.

I'm fine with either route: either checking Jenkins more frequently, or expanding the scope of what we do with Travis.

comment:7 Changed 17 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged both branches; now travis should distcheck for us

Note: See TracTickets for help on using tickets.