#25817 closed task (fixed)

Add ansible scripts for setup of nigthly build server

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: boklm201805, TorBrowserTeam201805R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should add to tor-browser-build/tools/ansible some ansible scripts to setup a nightly build machine.

This would make it easier to reinstall a nightly build machine, and could also be used by other people who want to make nightly builds.

Child Tickets

Change History (6)

comment:2 Changed 15 months ago by boklm

The new nightly build VM is now running at http://f4amtbsowhix7rrf.onion/, and has been set up using the ansible scripts in branch bug_25817. I still need to squash all the fixup commits in this branch before being able to merge it.

comment:3 Changed 15 months ago by boklm

Keywords: TorBrowserTeam201804R added; TorBrowserTeam201804 removed
Status: newneeds_review

The branch bug_25817_v7 is adding ansible roles used to setup a nightly build machine:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_25817_v7&id=9053f0f20f094b8cec2879c7c763d7bd45100039

comment:4 Changed 15 months ago by gk

Keywords: boklm201805 TorBrowserTeam201805 added; boklm201804 TorBrowserTeam201804R removed
Status: needs_reviewneeds_revision

Okay, looks mostly good. Some typos and one question.

s/setup/set up/ (when used as a verb)
"for an example of how they it be used" <- not sure which version you wanted to have :)

Now, I am a bit confused about the dependency to the test suite repo. Could you explain a bit more about how that is working. For instance, one thing I saw was that we already have a tor-browser-nightly.rbm.local.conf there but that one now gets overwritten with a newly added one we keep in the tbb-nightly-build dir in tor-browser-build but used afterwards which is a bit confusing.

comment:5 in reply to:  4 Changed 15 months ago by boklm

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201805 removed
Status: needs_revisionneeds_review

Replying to gk:

Okay, looks mostly good. Some typos and one question.

s/setup/set up/ (when used as a verb)
"for an example of how they it be used" <- not sure which version you wanted to have :)

I fixed those typos in branch bug_25817_v8:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_25817_v8&id=a2f565643d4c34a49712c37e3931dd6f80da7ba1

Now, I am a bit confused about the dependency to the test suite repo. Could you explain a bit more about how that is working. For instance, one thing I saw was that we already have a tor-browser-nightly.rbm.local.conf there but that one now gets overwritten with a newly added one we keep in the tbb-nightly-build dir in tor-browser-build but used afterwards which is a bit confusing.

We use the testsuite repo to generate build report pages on http://f4amtbsowhix7rrf.onion/reports/index-tor-browser_build.html.

Before the setup was done using ansible, we were storing some configuration files for the nightly builds in the test suite repo, but we are not using them anymore. To avoid confusion, I removed them from the test suite repo in commit 348ad855711382089c4fbf1badfec58e31a6c148. I also updated the README in tor-browser-build to remove references to those files, and instead recommend using the ansible roles for the setup.

comment:6 Changed 15 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay! Thanks for the explanation and fixups. I merged this to master (commit a2f565643d4c34a49712c37e3931dd6f80da7ba1). I think it would be worthwhile thinking about disentangling the *build* parts of the nightly builds from the *test* parts in tor-browser-bundle-testsuite but I am not feeling too strongly about that.

Note: See TracTickets for help on using tickets.