The new nightly build VM is now running at http://f4amtbsowhix7rrf.onion/, and has been set up using the ansible scripts in branch bug_25817. I still need to squash all the fixup commits in this branch before being able to merge it.
Okay, looks mostly good. Some typos and one question.
s/setup/set up/ (when used as a verb)
"for an example of how they it be used" <- not sure which version you wanted to have :)
Now, I am a bit confused about the dependency to the test suite repo. Could you explain a bit more about how that is working. For instance, one thing I saw was that we already have a tor-browser-nightly.rbm.local.conf there but that one now gets overwritten with a newly added one we keep in the tbb-nightly-build dir in tor-browser-build but used afterwards which is a bit confusing.
Now, I am a bit confused about the dependency to the test suite repo. Could you explain a bit more about how that is working. For instance, one thing I saw was that we already have a tor-browser-nightly.rbm.local.conf there but that one now gets overwritten with a newly added one we keep in the tbb-nightly-build dir in tor-browser-build but used afterwards which is a bit confusing.
Before the setup was done using ansible, we were storing some configuration files for the nightly builds in the test suite repo, but we are not using them anymore. To avoid confusion, I removed them from the test suite repo in commit 348ad855711382089c4fbf1badfec58e31a6c148. I also updated the README in tor-browser-build to remove references to those files, and instead recommend using the ansible roles for the setup.
Trac: Status: needs_revision to needs_review Keywords: TorBrowserTeam201805 deleted, TorBrowserTeam201805R added
Okay! Thanks for the explanation and fixups. I merged this to master (commit a2f565643d4c34a49712c37e3931dd6f80da7ba1). I think it would be worthwhile thinking about disentangling the build parts of the nightly builds from the test parts in tor-browser-bundle-testsuite but I am not feeling too strongly about that.
Trac: Status: needs_review to closed Resolution: N/Ato fixed