Opened 13 months ago

Last modified 11 months ago

#25819 new enhancement

Email committers on jenkins compile+test failures

Reported by: mikeperry Owned by: weasel
Priority: Medium Milestone:
Component: Internal Services/Service - jenkins Version:
Severity: Normal Keywords:
Cc: nickm, isis Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Can we make a jenkins hook to email committers since the last successful build upon build failure?

One reason that this has not been done in the past is because jenkins often has false positives in the form of dead/bad/incomplete build environments.

So: How about this hook only bother to email people if a build has made it past ./configure and into actual compilation stage?

Sure, there may be random things like ASAN executables that fail to run because of a bug in the new ASAN version for a platform, but that just means we should write autoconf tests to catch things like that.

Child Tickets

Change History (8)

comment:1 Changed 13 months ago by weasel

Hm.

I don't think jenkins has any way to distinguish failures before/at configure from those that happen afterwards.

A build is the entire run, and it either works or fails.

comment:2 Changed 13 months ago by mikeperry

Well what if the mailer hook inspected every failure, and then grepped the plaintext console output log for "^+ make -k$" ?

If the grep comes up empty, then the hook shouldn't mail. But if that grep comes up non-empty, then the build script made it past autogen and into the build, and then should be very likely a committer-caused failure.

comment:3 Changed 13 months ago by weasel

I wouldn't know where to start.

This is our current mailing setup:

https://gitweb.torproject.org/project/jenkins/jobs.git/tree/defaults.yaml#n3

If you can provide patches or directions we can look into it more.

comment:4 Changed 13 months ago by mikeperry

Hrmm. Can we install plugins? This could give us the hook we need:
https://github.com/jenkinsci/postbuildscript-plugin

comment:5 Changed 13 months ago by weasel

I do wonder if "jenkins often has false positives in the form of dead/bad/incomplete build environments" is actually true.

Have you done the numbers?

comment:7 Changed 11 months ago by weasel

All of these fetched the repository and failed during build.

comment:8 Changed 11 months ago by mikeperry

Ah, I see, that is the console log for the launch of both archs, and only one of the archs failed. I was confused by teh jenkins UI.

Note: See TracTickets for help on using tickets.