Opened 2 years ago

Closed 2 years ago

#25828 closed defect (fixed)

Our "has our write bucket been empty recently" check is dependent on TokenBucketRefillInterval

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #25373 Points:
Reviewer: Sponsor:


Found while working on #25373.

We have a variable called write_buckets_empty_last_second, but it is not accurate: it is re-checked and re-set every TokenBucketRefillInterval, which is currently 100ms.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by nickm

(I've fixed this as part of my #25373 work in a branch called lazy_bucket_refill, but it's not ready for review.)

comment:2 Changed 2 years ago by nickm

Resolution: fixed
Status: assignedclosed

Merging parent.

Note: See TracTickets for help on using tickets.