Opened 5 months ago

Closed 4 months ago

#25848 closed enhancement (fixed)

Replace Gson with Jackson in Onionoo

Reported by: iwakeh Owned by: karsten
Priority: High Milestone: Onionoo 1.14.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: #25815 Points:
Reviewer: Sponsor:

Description

This ticket should take the proof-of-concept branch from the parent ticket and replace gson thoroughly.
Steps:

  • remove gson from dependencies
  • adapt existing tests, which check part of the escape/unescape issues
  • look at the possible pitfalls b/c of different escape strategies (cf. parent ticket for more)
  • all touched classes should replace string concatenation in log statements in a separate commit (a step more towards to Metrics coding standards)
  • clean-up proof-of-concept branch to not print stack-traces and the like

Child Tickets

Change History (9)

comment:1 Changed 5 months ago by irl

#24021 ):

Edit: Although.. maybe this is a good time to move those classes into metrics-lib and then metrics-bot can share them.

Last edited 5 months ago by irl (previous) (diff)

comment:2 Changed 4 months ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

I'll start working on this.

comment:3 Changed 4 months ago by karsten

Priority: MediumHigh
Summary: Replace Gson with JacksonReplace Gson with Jackson in Onionoo

I made some progress on this, but decided to focus on metrics-lib (#26159) and CollecTor (#26162) first. I'll keep working on this one and also on equivalents for metrics-web and ExoneraTor.

comment:4 Changed 4 months ago by karsten

Status: acceptedneeds_review

comment:5 Changed 4 months ago by iwakeh

In order to not forget:

  private final String[] collecTorHosts = new String[] {
      "collector.torproject.org"/*, "collector2.torproject.org"*/ };
  // TODO do not merge the above!

Uncomment collector2 again.

comment:6 Changed 4 months ago by iwakeh

All ant test and checks pass. Looks fine except for the comment above and that it would be nice to at least adapt the touched logging statements to our standards.

comment:7 in reply to:  6 Changed 4 months ago by karsten

Replying to iwakeh:

All ant test and checks pass. Looks fine except for the comment above

Please see squash commit e8bbad0 in my task-25848 branch.

and that it would be nice to at least adapt the touched logging statements to our standards.

Please see squash commit 409eb19 in my task-25848 branch.

comment:8 Changed 4 months ago by iwakeh

Status: needs_reviewmerge_ready

Looks fine and passes all checks & tests.

comment:9 Changed 4 months ago by karsten

Milestone: Onionoo 1.14.0
Resolution: fixed
Status: merge_readyclosed

Merged, released, and deployed. Closing.

Note: See TracTickets for help on using tickets.