Ship tor in Tor Browser nightly builds for Windows with Rust enabled

Similar to #25481 (moved) we want to start shipping tor with Rust support enabled in our nightly builds for Windows.

added GeorgKoppen201902 TorBrowserTeam201902R boklm201811 component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-rbm type::defect labels

boklm201804 -> boklm201805

Trac:
Keywords: boklm201804 deleted, boklm201805 added

We need help from the network team with that. It's not necessary for the switch to ESR60, though.

Trac:
Keywords: ff60-esr deleted, N/A added

boklm201805 -> boklm201806

Trac:
Keywords: boklm201805 deleted, boklm201806 added

Trac:
Parent: #25220 (moved) to N/A

boklm201806 -> boklm201807

Trac:
Keywords: boklm201806 deleted, boklm201807 added

boklm201807 -> boklm201809

Trac:
Keywords: boklm201807 deleted, boklm201809 added

boklm201809 -> boklm201811

Trac:
Keywords: boklm201809 deleted, boklm201811 added

Finally: bug_25849_v2 (commit 21677b3571d9a7975b50074673169c6a6dc83b05). Please review.

Trac:
Keywords: TorBrowserTeam201804 deleted, GeorgKoppen201902, TorBrowserTeam201902R added
Status: new to needs_review

Is that correct that you apply unwind_128.patch to Firefox Nightly also?

Replying to cypherpunks:

Is that correct that you apply unwind_128.patch to Firefox Nightly also?

Good catch. No, it is not correct. I hoped I can somehow avoid version comparisons. Maybe boklm has a good idea whether we can achieve that.

Trac:
Cc: N/A to boklm
Keywords: GeorgKoppen201902, TorBrowserTeam201902R deleted, N/A added
Status: needs_review to needs_revision

Replying to gk:

Replying to cypherpunks:

Is that correct that you apply unwind_128.patch to Firefox Nightly also?

Good catch. No, it is not correct. I hoped I can somehow avoid version comparisons. Maybe boklm has a good idea whether we can achieve that.

I think you can add something like this to projects/tor/config:

diff --git a/projects/tor/config b/projects/tor/config
index 80282ea..f4b8e8f 100644
--- a/projects/tor/config
+++ b/projects/tor/config
@@ -68,4 +68,5 @@ input_files:
     input_file_var:
       rust_version: 1.28.0
       prev_version: 1.27.2
+      unwind_128: '[% c("var/windows-i686") %]'
     enable: '[% (c("var/linux") || c("var/osx")) && c("var/nightly") %]'

And then use input_file_var/unwind_128 in the conditions to apply unwind_128.patch.

Thanks, that's a good idea. bug_25849_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_25849_v3&id=3de8afa44fa4a7078f917263147f6e19107e3141) has the adapted fix.

Trac:
Keywords: N/A deleted, GeorgKoppen201902, TorBrowserTeam201902R added

This looks good to me. I merged this to master with commit d500c61974ff1cdbccd31a64181aa10cb1e9482f.

Trac:
Resolution: N/A to fixed
Status: needs_revision to closed

closed

mentioned in issue #25862 (moved)

moved to tpo/applications/tor-browser#25849 (closed)