#25860 closed enhancement (fixed)

Clean up OpenSSL's configure options for Windows

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201806R, boklm201806
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There is no need to basically duplicate the CFLAGS and LDFLAGS in the Windows related configure_opts. We could just use things defined in rbm.conf I think (and set flag_mwindows to '').

Child Tickets

Change History (11)

comment:1 Changed 20 months ago by gk

Type: defectenhancement

comment:2 Changed 20 months ago by boklm

Yes, I think using the CFLAGS and LDFLAGS from rbm.conf makes sense.

comment:3 Changed 19 months ago by boklm

Keywords: boklm201805 TorBrowserTeam201805 added

comment:4 Changed 19 months ago by boklm

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201805 removed
Status: newneeds_review

comment:5 Changed 19 months ago by boklm

The branch bug_25860_v2 is based on bug_16472_v15 so it will need to be cherry-picked if #16472 needs revision.

comment:7 Changed 19 months ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201805R removed

Moving review tickets to June.

comment:8 Changed 18 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201806R removed
Status: needs_reviewneeds_revision

Looks mostly good. I think you have a typo in your commit message: "Avoid duplicating Windows CFLAGS and CFLAGS". The second "CFLAGS" was probably meant to be "LDFLAGS"?

comment:9 Changed 18 months ago by boklm

Keywords: boklm201806 added; boklm201805 removed

boklm201805 -> boklm201806

comment:10 in reply to:  8 Changed 18 months ago by boklm

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: needs_revisionneeds_review

Replying to gk:

Looks mostly good. I think you have a typo in your commit message: "Avoid duplicating Windows CFLAGS and CFLAGS". The second "CFLAGS" was probably meant to be "LDFLAGS"?

Yes, I fixed that in branch bug_25860_v5:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_25860_v5&id=ba7b30a920172233392fd9dc176631c3da25d5f0

comment:11 Changed 18 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master as commit ba7b30a920172233392fd9dc176631c3da25d5f0.

Note: See TracTickets for help on using tickets.