Opened 3 months ago

Closed 6 weeks ago

#25894 closed defect (fixed)

Get a rust cross-compiler for Windows

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff60-esr, boklm201805, TorBrowserTeam201806R
Cc: Actual Points:
Parent ID: #25849 Points:
Reviewer: Sponsor:

Description

We want to build our own rust compiler for building then the Firefox and tor rust parts.

Child Tickets

Change History (8)

comment:1 Changed 3 months ago by gk

Keywords: TorBrowserTeam201804R added; TorBrowserTeam201804 removed
Priority: MediumHigh
Status: newneeds_review

Okay, a patch for review is up at bug_25894 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_25894&id=5d6c53155f6fc8d49185dde166ac0471ba2347ae) in my public tor-browser-build repo. It needs #25862 and #25832 fixed before, though (which we want to have anyway for switching to ESR 60 I think).

The 32bit cross-compilation has been a huge pain in the butt because it is essentially broken right now. For details, see: https://github.com/rust-lang/rust/issues/12859. Thanks to the help of Alex Crichton and Manish Goregaokar I was able to come up with a minimal patch that works around that problem.

I verified that the resulting x86_64 Rust toolchain is able to compile the necessary Rust bits shipped in ESR 60.

comment:3 Changed 3 months ago by gk

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201804R removed

Moving review tickets to May.

comment:4 Changed 3 months ago by boklm

Keywords: boklm201805 added; boklm201804 removed

boklm201804 -> boklm201805

comment:5 Changed 8 weeks ago by gk

Priority: HighVery High

Adjusting prios of some tickets.

comment:6 Changed 7 weeks ago by boklm

This patch looks good to me. I rebased it on master and #25832, fixing the conflicts with the macOS patch:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_25894_v2&id=4d5e3d2ba5422b931a2e32a9498feabec6ecc23e

And I am now trying a build of rust with this branch.

comment:7 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201805R removed

Moving review tickets to June.

comment:8 Changed 6 weeks ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good. I pushed this patch to master as commit 4d5e3d2ba5422b931a2e32a9498feabec6ecc23e.

Note: See TracTickets for help on using tickets.