Only run retry_dns() and check_dns_honesty() on exits

These periodic callbacks can become exit-only, since only exits now need to use the dns.c module.

changed milestone to %Tor: unspecified

added 034-roadmap-subtask 035-removed-20180711 040-deferred-20190220 component::core tor/tor milestone::Tor: unspecified parent::25500 priority::medium severity::normal sponsor::19 status::new type::enhancement labels

Trac:
Keywords: N/A deleted, 034-roadmap-subtask added
Cc: dgoulet to N/A
Owner: nickm to dgoulet
Component: - Select a component to Core Tor/Tor
Status: assigned to accepted

See branch ticket25899.

Trac:
Status: accepted to needs_review
Reviewer: N/A to dgoulet

Trac:
Owner: dgoulet to nickm
Status: needs_review to assigned

Trac:
Status: assigned to needs_review

nickm mentionned that things will changed through another branch or new commit(s).

Trac:
Status: needs_review to assigned

David said he'd be trying this one.

Trac:
Owner: nickm to dgoulet

See branch: ticket25899_034_01.

(It is really the original version of nickm's ticket25899 but on latest master).

Trac:
Status: assigned to needs_review

Merged!

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

Trac:
Status: closed to reopened
Resolution: implemented to N/A

Actually, dgoulet reports a bug here. so, not merging.

Also it needs a changes file.

Trac:
Status: reopened to needs_revision

Ok turns out that DNS and Exit Policy settings are kind of linked together...

For instance, when building our routerinfo object, we append "reject *" if our DNS init failed but this patch is about trying to initializing the DNS by looking if we are configured as an Exit... so the approach gets a bit more complicated.

Furthermore, check_dns_honesty_event() can be launched through the dns_init() code path which means it somehow needs to be enabled which only gets called in the initialized event callback which is after the first dns_init() call in do_main_loop()....

Bottom line, there seems to be some complexity with this one so deferring to 035. Not too big of a deal if a non-Exit relay launches those events.

Trac:
Milestone: Tor: 0.3.4.x-final to Tor: 0.3.5.x-final
Reviewer: dgoulet to N/A

Removing needs_revision tickets from 0.3.5 that seem to be stalled. Please move back if they are under active revision or discussion.

Trac:
Milestone: Tor: 0.3.5.x-final to Tor: unspecified
Keywords: N/A deleted, 035-removed-20180711 added

Trac:
Milestone: Tor: unspecified to Tor: 0.3.6.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

Trac:
Milestone: Tor: 0.3.6.x-final to Tor: 0.4.0.x-final

Trac:
Sponsor: N/A to Sponsor19

Deferring 51 tickets from 0.4.0.x-final. Tagging them with 040-deferred-20190220 for visibility. These are the tickets that did not get 040-must, 040-can, or tor-ci.

Trac:
Keywords: N/A deleted, 040-deferred-20190220 added
Milestone: Tor: 0.4.0.x-final to Tor: unspecified

dgoulet will assign himself to the ones he is working on right now.

Trac:
Status: needs_revision to assigned
Owner: dgoulet to N/A

Change tickets that are assigned to nobody to "new".

Trac:
Status: assigned to new

mentioned in issue #27212 (moved)

moved to tpo/core/tor#25899