Opened 11 months ago

Last modified 4 weeks ago

#25899 needs_revision enhancement

Only run retry_dns() and check_dns_honesty() on exits

Reported by: nickm Owned by: dgoulet
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, 035-removed-20180711, 040-deferred-20190220
Cc: Actual Points:
Parent ID: #25500 Points:
Reviewer: Sponsor: Sponsor19

Description

These periodic callbacks can become exit-only, since only exits now need to use the dns.c module.

Child Tickets

TicketTypeStatusOwnerSummary
#27212defectclosedWhy do bridges run the retry_dns callback?

Change History (16)

comment:1 Changed 11 months ago by dgoulet

Cc: dgoulet removed
Component: - Select a componentCore Tor/Tor
Keywords: 034-roadmap-subtask added
Owner: changed from nickm to dgoulet
Status: assignedaccepted

comment:2 Changed 11 months ago by nickm

Reviewer: dgoulet
Status: acceptedneeds_review

See branch ticket25899.

comment:3 Changed 11 months ago by dgoulet

Owner: changed from dgoulet to nickm
Status: needs_reviewassigned

comment:4 Changed 11 months ago by dgoulet

Status: assignedneeds_review

comment:5 Changed 11 months ago by dgoulet

Status: needs_reviewassigned

nickm mentionned that things will changed through another branch or new commit(s).

comment:6 Changed 10 months ago by nickm

Owner: changed from nickm to dgoulet

David said he'd be trying this one.

comment:7 Changed 10 months ago by dgoulet

Status: assignedneeds_review

See branch: ticket25899_034_01.

(It is really the original version of nickm's ticket25899 but on latest master).

comment:8 Changed 10 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged!

comment:9 Changed 10 months ago by nickm

Resolution: implemented
Status: closedreopened

comment:10 Changed 10 months ago by nickm

Status: reopenedneeds_revision

Actually, dgoulet reports a bug here. so, not merging.

Also it needs a changes file.

comment:11 Changed 10 months ago by dgoulet

Milestone: Tor: 0.3.4.x-finalTor: 0.3.5.x-final
Reviewer: dgoulet

Ok turns out that DNS and Exit Policy settings are kind of linked together...

For instance, when building our routerinfo object, we append "reject *" if our DNS init failed but this patch is about trying to initializing the DNS by looking if we are configured as an Exit... so the approach gets a bit more complicated.

Furthermore, check_dns_honesty_event() can be launched through the dns_init() code path which means it somehow needs to be enabled which only gets called in the initialized event callback which is _after_ the first dns_init() call in do_main_loop()....

Bottom line, there seems to be some complexity with this one so deferring to 035. Not too big of a deal if a non-Exit relay launches those events.

comment:12 Changed 8 months ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

Removing needs_revision tickets from 0.3.5 that seem to be stalled. Please move back if they are under active revision or discussion.

comment:13 Changed 5 months ago by dgoulet

Milestone: Tor: unspecifiedTor: 0.3.6.x-final

comment:14 Changed 4 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:15 Changed 2 months ago by gaba

Sponsor: Sponsor19

comment:16 Changed 4 weeks ago by nickm

Keywords: 040-deferred-20190220 added
Milestone: Tor: 0.4.0.x-finalTor: unspecified

Deferring 51 tickets from 0.4.0.x-final. Tagging them with 040-deferred-20190220 for visibility. These are the tickets that did not get 040-must, 040-can, or tor-ci.

Note: See TracTickets for help on using tickets.