Opened 3 years ago

Closed 3 years ago

#25901 closed defect (fixed)

hs-v3: Memleak on SIGHUP

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, 032-backport, 033-backport, memleak, fast-fix
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


On SIGHUP, we move the hs state between service objects.

Because hs_service_new() allocates the replaycache by default, we overwrite it within move_hs_state():

  dst->replay_cache_rend_cookie = src->replay_cache_rend_cookie;

We have to free the dst cache before.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by dgoulet

Status: assignedmerge_ready

Branch: bug25901_032_01

Quite trivial. Going in merge_ready.

comment:2 Changed 3 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merging to 0.3.2 and forward.

Note: See TracTickets for help on using tickets.