disable updater telemetry

Between Firefox ESR 52 and ESR 60, Mozilla added telemetry pings to the updater codepaths. Unfortunately, some pings are not correctly disabled when telemetry is disabled.

added TorBrowserTeam201805 component::applications/tor browser ff60-esr owner::tbb-team priority::medium resolution::fixed severity::normal status::closed type::defect labels

Trac:
0001-fixup-TB4-Tor-Browser-s-Firefox-preference-overrides.patch

Trac:
0002-Bug-25909-disable-updater-telemetry.patch

The attached patches fix this issue. The 0001- patch is a fixup that sets toolkit.telemetry.enabled to false so that the 0002- patch can reference it.

We should probably ask for this to be upstreamed. The code that Kathy and I patched was added for https://bugzilla.mozilla.org/show_bug.cgi?id=1380256

Trac:
Keywords: TorBrowserTeam201804 deleted, TorBrowserTeam201804R added
Status: new to needs_review

Replying to mcs:

We should probably ask for this to be upstreamed. The code that Kathy and I patched was added for https://bugzilla.mozilla.org/show_bug.cgi?id=1380256

Sounds good to me. Could you file an upstream report attaching your patch/getting it into a needs_review shape and into mozilla-central?

Moving review tickets to May.

Trac:
Keywords: TorBrowserTeam201804R deleted, TorBrowserTeam201805R added

It seems to me we don't need the _enabled check? Because you are setting Telemetry usage to false in the first patch, so we should we good without _enabled usage (in fact the latter makes the pref flip obsolete by never ever sending a ping). Or maybe I am missing something here?

Trac:
Keywords: TorBrowserTeam201805R deleted, TorBrowserTeam201805 added
Status: needs_review to needs_revision

Replying to gk:

It seems to me we don't need the _enabled check? Because you are setting Telemetry usage to false in the first patch, so we should we good without _enabled usage (in fact the latter makes the pref flip obsolete by never ever sending a ping). Or maybe I am missing something here?

The _enabled check is not needed for Tor Browser, but since Firefox supports a separate toolkit.telemetry.updatePing.enabled pref we thought we should write the patch in the form Mozilla will want it. Kathy and I have not found time to file a Bugzilla bug yet though.

Okay, makes sense.

This got actually applied to tor-browser-60.0.1esr-8.0-1 (as commit 7ca562c26856b7a413854600cd9ae44ddbaf3462). mcs/brade: Could you just open the Moz bug and then close this ticket?

Trac:
Status: needs_revision to needs_information

I created https://bugzilla.mozilla.org/show_bug.cgi?id=1466857 to track this on the Mozilla side.

Trac:
Resolution: N/A to fixed
Status: needs_information to closed

closed

moved to tpo/applications/tor-browser#25909 (closed)