Opened 2 months ago

Closed 3 weeks ago

#25909 closed defect (fixed)

disable updater telemetry

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201805
Cc: arthuredelstein, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Between Firefox ESR 52 and ESR 60, Mozilla added telemetry pings to the updater codepaths. Unfortunately, some pings are not correctly disabled when telemetry is disabled.

Child Tickets

Attachments (2)

Change History (12)

comment:1 Changed 2 months ago by mcs

The attached patches fix this issue. The 0001- patch is a fixup that sets toolkit.telemetry.enabled to false so that the 0002- patch can reference it.

comment:2 Changed 2 months ago by mcs

We should probably ask for this to be upstreamed. The code that Kathy and I patched was added for https://bugzilla.mozilla.org/show_bug.cgi?id=1380256

comment:3 Changed 2 months ago by mcs

Keywords: TorBrowserTeam201804R added; TorBrowserTeam201804 removed
Status: newneeds_review

comment:4 in reply to:  2 Changed 7 weeks ago by gk

Replying to mcs:

We should probably ask for this to be upstreamed. The code that Kathy and I patched was added for https://bugzilla.mozilla.org/show_bug.cgi?id=1380256

Sounds good to me. Could you file an upstream report attaching your patch/getting it into a needs_review shape and into mozilla-central?

comment:5 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201804R removed

Moving review tickets to May.

comment:6 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201805 added; TorBrowserTeam201805R removed
Status: needs_reviewneeds_revision

It seems to me we don't need the _enabled check? Because you are setting Telemetry usage to false in the first patch, so we should we good without _enabled usage (in fact the latter makes the pref flip obsolete by never ever sending a ping). Or maybe I am missing something here?

comment:7 in reply to:  6 Changed 5 weeks ago by mcs

Replying to gk:

It seems to me we don't need the _enabled check? Because you are setting Telemetry usage to false in the first patch, so we should we good without _enabled usage (in fact the latter makes the pref flip obsolete by never ever sending a ping). Or maybe I am missing something here?

The _enabled check is not needed for Tor Browser, but since Firefox supports a separate toolkit.telemetry.updatePing.enabled pref we thought we should write the patch in the form Mozilla will want it. Kathy and I have not found time to file a Bugzilla bug yet though.

comment:8 Changed 5 weeks ago by gk

Okay, makes sense.

comment:9 Changed 3 weeks ago by gk

Status: needs_revisionneeds_information

This got actually applied to tor-browser-60.0.1esr-8.0-1 (as commit 7ca562c26856b7a413854600cd9ae44ddbaf3462). mcs/brade: Could you just open the Moz bug and then close this ticket?

comment:10 Changed 3 weeks ago by mcs

Resolution: fixed
Status: needs_informationclosed

I created https://bugzilla.mozilla.org/show_bug.cgi?id=1466857 to track this on the Mozilla side.

Note: See TracTickets for help on using tickets.