Opened 20 months ago

Last modified 6 months ago

#25913 needs_information defect

If our win32 monotonic timers are not monotonic, make them so.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There's a rumor that sometimes GetTickCount64 or GetTickCount can move backwards. This is possibly due to a misunderstanding of bug #23558 (fixed with 77cc97cf0a20ed0a062a1cb87bef6c40941e4cff). But in case it isn't, we should fix it.

(QueryPerformanceCounter *can* move backwards, and we have code to handle that.)

Putting this ticket in tor:unspecified since I don't actually think we have a bug here.

Child Tickets

Change History (4)

comment:1 Changed 20 months ago by nickm

I have a branch, ratchet_gettickcount, against maint-0.2.9.

Not putting this in needs_review, since again we don't actually know we have a Windows bug to work around here.

comment:2 Changed 6 months ago by nickm

Status: assignedneeds_information

Does this bug actually occur? If so, we should revise and merge this patch.

comment:3 Changed 6 months ago by nickm

Owner: nickm deleted
Status: needs_informationassigned

I'm listed as the owner of these needs_information tickets, but I'm not currently doing anything with them. Reassigning to nobody, then putting back in needs_information.

comment:4 Changed 6 months ago by nickm

Status: assignedneeds_information
Note: See TracTickets for help on using tickets.