Update gcc to 8.X

We should build Tor Browser using gcc 7.3.0. Firefox meta is https://bugzilla.mozilla.org/show_bug.cgi?id=1320654. The only thing to check is https://hg.mozilla.org/mozilla-central/rev/48ff50f0db50. Porting guide is https://gcc.gnu.org/gcc-7/porting_to.html. LRA is the default https://gcc.gnu.org/wiki/LRAIsDefault. -mindirect-branch=thunk is available.

added GeorgKoppen201905 TorBrowserTeam201905R component::applications/tor browser owner::tbb-team parent::30321 priority::medium resolution::fixed severity::normal status::closed tbb-rbm type::task labels

That's nothing for ESR 60. We stick to 6.x for Tor Browser 8.

Trac:
Parent: #24631 (moved) to N/A

#29335 (moved) is a duplicate.

Trac:
Summary: Update gcc to 7.3.0 to Update gcc to 7.X

We could get -fwrapv back for our debug builds if we switched to GCC 8.x (see: #27597 (moved)). As a data point: I've been compiling (and using) some custom Tor Browser with GCC 8.x for a while now and did not run into any issues. Thus, we might consider 8.x sufficiently stable to switch to it in particular when preparing for eser68.

Trac:
Parent: N/A to #30321 (moved)

GCC 9.1 is better (#30475 (moved)). About Firefox: https://hubicka.blogspot.com/2019/05/gcc-9-link-time-and-inter-procedural.html Hah: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88702

I think it's good to be conservative here and not switching to GCC 9.1 right away. It seems using GCC 8.3.0 is a decent solution for our Tor Browser 9. bug_25930_v3(https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_25930_v3&id=e8bf1330d8e5e5ccc48d69d47ab424ce746c30ee) has the proposed fix. Note: I am leaving mingw-w64/gcc untouched for now. All things seem to build fine, just our spec hack for Firefox is breaking. But that should get fixed by mingw-w64/clang anyway, so we bump the GCC part for mingw-w64/gcc after we switched Firefox to mingw-w64/clang (#28238 (moved)).

Trac:
Status: new to needs_review
Summary: Update gcc to 7.X to Update gcc to 8.X
Keywords: N/A deleted, GeorgKoppen201905, TorBrowserTeam201905R added

This looks good to me. I merged this to master with commit ae8f6de9939dd372945bea063245ab7123019cb6.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #29335 (moved)

mentioned in issue #30321 (moved)

mentioned in issue #30377 (moved)

moved to tpo/applications/tor-browser#25930 (closed)