Opened 15 months ago

Closed 2 months ago

#25930 closed task (fixed)

Update gcc to 8.X

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201905R, GeorgKoppen201905
Cc: Actual Points:
Parent ID: #30321 Points:
Reviewer: Sponsor:

Description

We should build Tor Browser using gcc 7.3.0.
Firefox meta is https://bugzilla.mozilla.org/show_bug.cgi?id=1320654.
The only thing to check is https://hg.mozilla.org/mozilla-central/rev/48ff50f0db50.
Porting guide is https://gcc.gnu.org/gcc-7/porting_to.html.
LRA is the default https://gcc.gnu.org/wiki/LRAIsDefault.
-mindirect-branch=thunk is available.

Child Tickets

TicketStatusOwnerSummaryComponent
#30377closedtbb-teamRemove Selfrando from our build systemApplications/Tor Browser

Change History (8)

comment:1 Changed 15 months ago by gk

Parent ID: #24631

That's nothing for ESR 60. We stick to 6.x for Tor Browser 8.

comment:2 Changed 6 months ago by gk

#29335 is a duplicate.

comment:3 Changed 6 months ago by gk

Summary: Update gcc to 7.3.0Update gcc to 7.X

comment:4 Changed 5 months ago by gk

We could get -fwrapv back for our debug builds if we switched to GCC 8.x (see: #27597). As a data point: I've been compiling (and using) some custom Tor Browser with GCC 8.x for a while now and did not run into any issues. Thus, we might consider 8.x sufficiently stable to switch to it in particular when preparing for eser68.

comment:5 Changed 3 months ago by gk

Parent ID: #30321

comment:7 Changed 2 months ago by gk

Keywords: TorBrowserTeam201905R GeorgKoppen201905 added
Status: newneeds_review
Summary: Update gcc to 7.XUpdate gcc to 8.X

I think it's good to be conservative here and not switching to GCC 9.1 right away. It seems using GCC 8.3.0 is a decent solution for our Tor Browser 9. bug_25930_v3(https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_25930_v3&id=e8bf1330d8e5e5ccc48d69d47ab424ce746c30ee) has the proposed fix. Note: I am leaving mingw-w64/gcc untouched for now. All things seem to build fine, just our spec hack for Firefox is breaking. But that should get fixed by mingw-w64/clang anyway, so we bump the GCC part for mingw-w64/gcc after we switched Firefox to mingw-w64/clang (#28238).

comment:8 Changed 2 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good to me. I merged this to master with commit ae8f6de9939dd372945bea063245ab7123019cb6.

Note: See TracTickets for help on using tickets.