#25931 closed defect (implemented)

Move consdiffmgr_rescan() into its own callback

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328
Cc: Actual Points:
Parent ID: #25375 Points:
Reviewer: dgoulet Sponsor: Sponsor8

Description

We run this callback in second_elapsed_callback, but we don't have to: The rules for running it are extremely simple.

Child Tickets

Change History (5)

comment:1 Changed 18 months ago by nickm

Status: assignedneeds_review

For review as ticket25931. Very small.

comment:2 Changed 18 months ago by dgoulet

With this patch we lose this safeguard. On purpose?

-  if (dir_server_mode(options)) {
-    consdiffmgr_rescan();
-  }

comment:3 Changed 18 months ago by nickm

I believe that's safe, yeah. We can only schedule the rescan if we actually need it.

comment:4 Changed 18 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

Oh I see now, we set up the postloop event if the cache is init for which only directory server do. Great!

lgtm;

comment:5 Changed 18 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.