Opened 5 months ago

Closed 5 months ago

#25932 closed defect (implemented)

Close closeable objects in a postloop event, not in second_elapsed_callback().

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328
Cc: Actual Points:
Parent ID: #25375 Points:
Reviewer: Sponsor: Sponsor8

Description

We currently close channels, channel listeners, connections, and circuits as part of our second_elapsed_callback(). But since all pending-close objects are kept in lists, we can just do this in a post-loop event.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by nickm

Status: assignedneeds_review

See branch ticket25932. Also pretty easy.

comment:2 Changed 5 months ago by dgoulet

Status: needs_reviewmerge_ready

lgtm;

comment:3 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.