Opened 2 years ago

Closed 2 years ago

#25933 closed defect (implemented)

Remove connection_ap_attach_pending(0) from per-second callback.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328
Cc: Actual Points:
Parent ID: #25375 Points:
Reviewer: dgoulet Sponsor: Sponsor8


Thanks to the attach_pending_entry_connections_ev logic, this call doesn't need to be in the per-second callback at all.

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by nickm

Status: assignedneeds_review

See branch ticket25933.

Note that this reverts a change we made for #19969, so we should make sure that change is no longer necessary.

comment:2 Changed 2 years ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

I believe this is correct.

We set untried_pending_connections = 1 just before activating the postloop event meaning we will pass over the pending connections soon after.


comment:3 Changed 2 years ago by nickm

Resolution: implemented
Status: merge_readyclosed


Note: See TracTickets for help on using tickets.