Opened 4 months ago

Closed 4 months ago

#25936 closed defect (fixed)

have travis display test-suite.log from the right place when DISTCHECK=yes

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ci, fast-fix, 029-backport, 031-backport, 032-backport, 033-backport
Cc: Actual Points:
Parent ID: #25550 Points:
Reviewer: isis Sponsor: Sponsor3-can

Description

After #25814, Travis CI sometimes won't find test-suite.log because make distcheck runs make check in a subdirectory. This causes problems when there's a failure that's specific to make distcheck, like in this example.

We should create a new make target that shows test-suite.log from the correct place. (It's easier if it's a make target because then we have $(distdir) available.)

Child Tickets

Change History (6)

comment:1 Changed 4 months ago by catalyst

Status: assignedneeds_review

Pull request for 0.2.9: https://github.com/torproject/tor/pull/61
My bug25936-03{1,3} branches contain the conflict resolution merge commits for those supported releases (though they're fairly straightforward).

comment:2 Changed 4 months ago by catalyst

Parent ID: #25550

comment:3 Changed 4 months ago by dgoulet

Reviewer: isis

comment:4 Changed 4 months ago by isis

Status: needs_reviewmerge_ready

LGTM!

comment:5 Changed 4 months ago by dgoulet

Keywords: 029-backport 031-backport 032-backport 033-backport added

comment:6 Changed 4 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged to 0.2.9 and forward!

Note: See TracTickets for help on using tickets.