#25937 closed defect (implemented)

Move dirvote_act into a periodic callback

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328
Cc: Actual Points:
Parent ID: #25375 Points:
Reviewer: dgoulet Sponsor: Sponsor8

Description

Instead of calling dirvote_act once per second, we can just ask it when to call it next.

Child Tickets

Change History (9)

comment:1 Changed 16 months ago by nickm

I've started this as dirvote_act_refactor, but I'm going to rebase and finish it once #25376 is merged, to avoid conflicts.

comment:2 Changed 16 months ago by nickm

Status: assignedneeds_review

This has been rebased; the name is still dirvote_act_refactor. PR at https://github.com/torproject/tor/pull/62

comment:3 Changed 16 months ago by dgoulet

Status: needs_reviewneeds_revision

Reviewed done.

comment:4 Changed 16 months ago by nickm

(In any case, we should not merge this as-is -- it will need to be rebased because of the dirvote code movement in #25610)

comment:5 Changed 16 months ago by nickm

Status: needs_revisionneeds_review

Okay, I tried to answer your review; please let me know if you believe my answers :)

comment:6 Changed 16 months ago by dgoulet

Reviewer: dgoulet

comment:7 Changed 16 months ago by dgoulet

Status: needs_reviewneeds_revision

It all looks good but I do have a follow up on one part of it. Feel free to merge if addressed.

comment:8 Changed 16 months ago by nickm

Status: needs_revisionmerge_ready

I added the issue you mentioned (adding a comment), but I don't plan to merge until after #25610 is in -- I don't want conflicts with that one, since conflicts with code-movement commits can be super annoying.

comment:9 Changed 16 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Made a new branch "dirvote_act_refactor_v2" based on master, and then squashed it as "dirvote_act_refactor_v2_squashed". Then added an extra commit to refactor our timer subtraction logic to use a function we already had for the purpose, and merged to master!

Note: See TracTickets for help on using tickets.