Opened 8 months ago

Closed 8 months ago

#25951 closed defect (fixed)

Run flush_pending_log_callbacks() on an as-needed basis, not once-per-second

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328
Cc: Actual Points:
Parent ID: #25375 Points:
Reviewer: dgoulet Sponsor: Sponsor8

Description

This is likely to be trickier than a bunch of the other removals from our once-per-second code, since the logic to activate this event can happen from non-main threads.

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by nickm

Status: assignedneeds_review

https://github.com/torproject/tor/pull/69 is the PR

Note that this turned out to be easier than I'd thought, because we have a preexisting defect in that we already suppress a controller's log message events when those callbacks occur outside the main thread. We should fix that some time, but perhaps not now. See #25987 for ideas to fix that.

comment:2 Changed 8 months ago by dgoulet

Reviewer: dgoulet

comment:3 Changed 8 months ago by dgoulet

Status: needs_reviewmerge_ready

lgtm;

comment:4 Changed 8 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.