#25965 closed defect (implemented)

Document default value of Nickname parameter [patch]

Reported by: saper Owned by:
Priority: Very Low Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: doc
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While responding to an inquiry on IRC regarding Freedombox Plinth issue #1294: tor: let the user verify if the relay is connected I was wondering what happens if the Nickname is not set.

I had to refer to the source code to find out.

I have published a change that fixes this:

http://repo.or.cz/tor/appveyor.git/shortlog/refs/heads/default_nickname

("default_nickname" branch on http://repo.or.cz/tor/appveyor.git)

Child Tickets

Change History (4)

comment:1 Changed 16 months ago by teor

Keywords: doc added
Milestone: Tor: 0.3.3.x-final
Status: newneeds_revision

Thanks for this patch, but minor changes go in torrc-minimal.in-staging, not torrc-minimal.in.
Please make that change, and then flip to merge ready.

Assigning to 0.3.3 because it's still open to doc fixes.
We'll need to cherry-pick the commit, then marge forward.

comment:2 Changed 16 months ago by saper

Updated, thanks. Had no idea what this "staging" thing is. How long is the branch open? I have some further ideas to improve the manpage.

Last edited 16 months ago by saper (previous) (diff)

comment:3 in reply to:  2 Changed 16 months ago by teor

Status: needs_revisionmerge_ready

Replying to saper:

Updated, thanks. Had no idea what this "staging" thing is.

Thanks, this patch is ready to merge.

How long is the branch open? I have some further ideas to improve the manpage.

Just open another ticket, and it will go in whichever release is available.
We are on 0.3.3.5-rc, so this patch or your next patch might go in 0.3.4.

Or if your patch fixes something that's really bad, it might go all the way back to 0.2.9.

We'll make it work.

comment:4 Changed 16 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final
Resolution: implemented
Status: merge_readyclosed

Merged into master! (Not backporting.)

Note: See TracTickets for help on using tickets.