Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2597 closed task (fixed)

remove duplicate files from master's changes/ directory

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.3.1-alpha
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There are 71 files in master's changes/ directory

More than half of them are already in release-0.2.2, so they shouldn't show up again in 0.2.3.1-alpha's change log.

We should go through and git rm the ones that aren't going to be part of 0.2.3.1-alpha's changelog.

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by nickm

Status: newneeds_review

Somebody please check my logic here: It is definitely safe to remove a changes file in master if there _is_ some change to that file that occurred before origin/release-0.2.2, AND there are no changes to that file between origin/release-0.2.2 and master. If so, my branch "rm_changes" is probably correct.

Also in that branch is the perl script I used to find said changes files: I ran it as "cd changes; findMergedChanges.pl --merged * | xargs git rm"

comment:2 Changed 9 years ago by arma

branch looks good to me.

(i did not confirm that no redundant files remain, but i did confirm that i recognize all of the files that you've removed as being in 0.2.2 also.)

comment:3 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged & closed. thanks!

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.