Get a rust cross-compiler for macOS

We want to build our own rust compiler for building the Firefox and tor rust parts.

added GeorgKoppen201805R TorBrowserTeam201805R boklm201805 component::applications/tor browser ff60-esr owner::tbb-team parent::25779 priority::very high resolution::fixed severity::normal status::closed tbb-rbm type::defect labels

bug_25975 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_25975&id=56ee89b4b4b9ee8643cdb404018701ad200a9200) has a patch up for review.

Trac:
Priority: Medium to High
Keywords: TorBrowserTeam201804 deleted, TorBrowserTeam201805R added
Status: new to needs_review

boklm201804 -> boklm201805

Trac:
Keywords: boklm201804 deleted, boklm201805 added

Okay, this likely needs a revision as using a so-created Rust cross-compiler leads to:

 8:36.74 error[E0433]: failed to resolve. Could not find `__FastLocalKeyInner` in `thread`
 8:36.74   --> third_party/rust/futures/src/task_impl/std/mod.rs:28:1
 8:36.74    |
 8:36.74 28 | thread_local!(static CURRENT_TASK: Cell<*mut u8> = Cell::new(ptr::null_mut()));
 8:36.74    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Could not find `__FastLocalKeyInner` in `thread`
 8:36.74    |
 8:36.74    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
 8:36.74 
 8:36.75 error[E0433]: failed to resolve. Could not find `__FastLocalKeyInner` in `thread`
 8:36.75    --> third_party/rust/futures/src/task_impl/std/mod.rs:494:1
 8:36.75     |
 8:36.75 494 | / thread_local! {
 8:36.75 495 | |     static CURRENT_THREAD_NOTIFY: Arc<ThreadNotify> = Arc::new(ThreadNotify {
 8:36.75 496 | |         state: AtomicUsize::new(IDLE),
 8:36.75 497 | |         mutex: Mutex::new(()),
 8:36.75 498 | |         condvar: Condvar::new(),
 8:36.75 499 | |     });
 8:36.75 500 | | }
 8:36.75     | |_^ Could not find `__FastLocalKeyInner` in `thread`
 8:36.75     |
 8:36.75     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
 8:36.75 

Trac:
Keywords: GeorgKoppen201804 deleted, GeorgKoppen201805 added
Status: needs_review to needs_revision

__FastLocalKeyInner seems to be missing in our libstd .rlib, hm, yet I can see

thread :: __FastLocalKeyInner < $ t > = $ crate :: thread ::
__FastLocalKeyInner :: new (  ) ; # [ cfg ( not ( target_thread_local ) ) ]
static __KEY : $ crate :: thread :: __OsLocalKeyInner < $ t > = $ crate ::
thread :: __OsLocalKeyInner :: new (  ) ; __KEY . get (  ) } unsafe {

as in the lib downloaded via rustup.

Actually, we are good. The reason for this problem is that we are setting MACOSX__DEPLOYMENT_TARGET=10.6 which fits to the current toolchain we use. thread_local is not supported for 10.6 but it is for 10.7 onward. Thus, we are good for now and will be later on when switching to our new toolchain. I just tested that and could successfully build esr60.

I've rebased my patch on master and pushed an update to bug_25975_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_25975_v2&id=040cc0560eb21cf09dbdbbd33d501b805a28d6bd).

boklm could you review that one?

Trac:
Cc: N/A to boklm
Keywords: GeorgKoppen201805 deleted, GeorgKoppen201805R added
Status: needs_revision to needs_review

I didn't try to build it, but the patch looks good to me.

One minor thing: the line cat > $distdir/helper/x86_64-apple-darwin-clang << 'EOF' and the comment before can be indented.

Adjusting prios of some tickets.

Trac:
Priority: High to Very High

Replying to boklm:

I didn't try to build it, but the patch looks good to me.

One minor thing: the line cat > $distdir/helper/x86_64-apple-darwin-clang << 'EOF' and the comment before can be indented.

I fixed that and pushed the result to master as commit e7f9f6f11e45d1ba15fbbb183ef1ae8b0c3b20c5, thanks.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#25975 (closed)