Opened 17 months ago

Last modified 3 months ago

#25987 assigned defect

Allow controller to receive log messages from outside main thread

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: small, 035-removed-20180711, 040-roadmap-proposed
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Our existing callback system doesn't allow this, but actually it would be pretty easy to take care of.

The trick here would be:

1) to make it so that the flush_queued_events_event uses the alert_sockets_create() mechanism, so it can be turned on from another thread.
2) To remove the check for whether we're in the main thread from control_event_logmsg().

I think this would be pretty simple -- maybe a couple hours of work -- but we should consider it only for 0.3.5, since it has potential to be very destabilizing if we mess it up.

Found while working on #25951

Child Tickets

Change History (4)

comment:1 Changed 15 months ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

These tickets are being triaged out of 0.3.5. The ones marked "035-roadmap-proposed" may return.

comment:2 Changed 11 months ago by teor

Keywords: 036-roadmap-proposed added; 035-roadmap-proposed removed

This is potentially destabilising, so it belongs in 0.3.6 or later.

comment:3 Changed 11 months ago by teor

Keywords: 040-roadmap-proposed added; 036-roadmap-proposed removed

0.3.6 is now 0.4.0: changing roadmap keywords

comment:4 Changed 3 months ago by nickm

Owner: nickm deleted

These tickets are not things I'm currently working on. They may be important, but they don't need to be done by me specifically. Un-assigning.

Note: See TracTickets for help on using tickets.