Opened 2 years ago

Closed 2 years ago

#25988 closed defect (fixed)

module: Post-merge tasks for dirauth modularization

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, tor-dirauth, module
Cc: Actual Points:
Parent ID: #25610 Points:
Reviewer: Sponsor:


We've identified a series of things to do post-merge. They aren't that big and should be quite straightforward to achieve (no need to do them in that order):

  1. Splitting up dirvote_common.

nickm and I have discussed this and the decision is:

  • voting_schedule.{c|h} for the dirvote_common.c stuff
  • shared_random_client.{c|h} for shared_random_common.c.
  1. Adding more #ifdefs (nickm)
  1. Rename and move dirvote_get_voter_sig_by_alg()

We'll move this to networkstatus.c and namespace is networkstatus_

  1. Make dirvote_parse_sr_commits take a const ptr for tokens.

For this to happen, we need to refactor the code so find_opt_by_keyword() can take a const pointer.

  1. Add a changes file.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by dgoulet

Status: assignedneeds_review

Ok I did it all. Not too complicated. No commits change the code behavior. Should be fairly easy to review as most of it is renaming and moving code.

Branch: ticket25988_034_01

comment:2 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; tests pass. Merging!

Note: See TracTickets for help on using tickets.