Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#25996 closed defect (implemented)

Produce consistent coverage from test_client_pick_intro()

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ci, tor-tests-coverage, tor-tests-unit
Cc: asn, dgoulet Actual Points:
Parent ID: #25908 Points:
Reviewer: Sponsor: Sponsor3-can

Description

This test can produce different coverage, depending on whether the non-excluded introduction point is chosen first or not. To prevent this, we can just repeat the relevant portion of the test enough times.

Child Tickets

Change History (4)

comment:1 Changed 5 months ago by nickm

Cc: asn dgoulet added
Status: assignedneeds_review

The branch is ticket25996; https://github.com/torproject/tor/pull/75 is a PR.

Adding asn and dgoulet to the cc in their role as HS experts.

comment:2 Changed 5 months ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:3 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

comment:4 Changed 5 months ago by nickm

Sponsor: Sponsor3-can
Note: See TracTickets for help on using tickets.