Allow Tor to accept node_id at the end of a bandwidth file line

Tor doesn't accept node_id at the end of a line, because the trailing newline is part of the string at the end of the line. To fix this issue, we should make newline one of the separators in the string token list.

changed milestone to %Tor: 0.3.4.x-final

added 029-backport-maybe 031-backport-maybe 032-backport-maybe 033-backport-maybe 034-backport-maybe component::core tor/tor fast-fix milestone::Tor: 0.3.4.x-final parent::25925 priority::medium resolution::fixed reviewer::nickm severity::normal status::closed tor-bwauth type::defect labels

Trac:
Keywords: N/A deleted, 034-backport-maybe, 029-backport-maybe, 033-backport-maybe, 031-backport-maybe, 032-backport-maybe added

Could this be a solution? https://github.com/torproject/tor/compare/master...juga0:bug26004_maint-0.2.9_bw_newline

That looks like it will work, and it seems like it passes the tests. The checks are in a weird order, but we can fix that in a rewrite.

In our code style, we use character constants instead of integers. So 10 is '\n' and 0 is '\0'.

When we name branches, we call them after the tor branch they are based on. This branch is based on master, so it should not have "maint-0.2.9" in the name. Did you mean to base it on maint-0.2.9?

You can use "029" in branch names rather than "maint-0.2.9" if you want.

When you want a review on a ticket, you can put it in "needs_review".

Trac:
Status: new to needs_revision

Trac:
Keywords: N/A deleted, tor-dirauth added
Status: needs_revision to needs_review

Changed what you suggested. Yes, i meant to based in maint-0.2.9, isn't based on? I haven't renamed the branch, since probably should create another squashing commits. Opened PR following the naming proposed in the wiki (org/process/TorOnTrac).

Trac:
Reviewer: N/A to nickm

Two changes needed here:

• If the input to this function is the empty string, strlen(line) - 1 will underflow.
• This branch needs a changes file.

I've made both of these changes in my own branch (with the same name as yours) -- please let me know if you agree with them, and I'll merge.

Thanks for the review. Maybe log_warn should be lower, since in the spec we have so far we would allow files with empty bw lines?

Feel free to squash, if needed for the log to looks better

I've squashed this as bug26004_029_squashed, and merged it to master. Marking for possible backport!

Trac:
Milestone: Tor: 0.3.5.x-final to Tor: 0.3.3.x-final

Trac:
Status: needs_review to merge_ready

Trac:
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.4.x-final

All directory authorities that vote on bandwidths are running 0.3.3 or later. torflow and sbws do not produce lines with node_id at the end. (And all other generators should be able to obey this constraint.)

So I don't think we need to backport this fix.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

Trac:
Keywords: tor-dirauth deleted, tor-bwauth added

closed

moved to tpo/core/tor#26004 (closed)