Stop logging stack contents when reading a zero-length bandwidth file

When reading a zero-length bandwidth file, Tor directory authorities read an uninitialised buffer and log it at warning level.

There is no guarantee that the buffer contains a NUL byte.

changed milestone to %Tor: 0.3.4.x-final

added 029-backport 031-backport 032-backport 033-must-maybe component::core tor/tor fast-fix milestone::Tor: 0.3.4.x-final owner::teor parent::25925 priority::medium resolution::fixed reviewer::asn security-low severity::normal status::closed type::defect version::tor 0.2.2.1-alpha labels

Please see my branch bug26007_029 on https://github.com/teor2345/tor.git

Trac:
Status: assigned to needs_review

Oops, now it's force-pushed and based on 0.2.9.

lgtm, merging to 0.2.9 and forward

Can we have a regression test for this case?

Trac:
Status: needs_review to merge_ready

I think juga is working on a whole bunch of bwfile tests. Let's make sure one of them is a regression test for this case.

Trac:
Cc: N/A to juga

Trac:
Parent: N/A to #25925 (moved)

Test only for this in my branch ticket26007_01. It's using the same approach as the test for geoip, which adds a new file to the filestystem. Nickm, would you have an idea on a different approach than adding a new file here?. Also, it's based on master and not 0.2.9 because is using SRCDIR was introduced by nickm for the geoip test.

Trac:
Status: merge_ready to needs_revision
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.4.x-final

Trac:
Reviewer: N/A to nickm
Status: needs_revision to needs_review

Trac:
Reviewer: nickm to asn

WRT the question of how to avoid adding an extra file: you can use the "get_fname()" function to get a temporary filename from within a unit test, and then use write_str_to_file() to write a string into that file. The file will be automatically cleaned up when the unit tests exit.

For a very simple example, see test_util_listdir() in test_util.c .

Thanks!, that was very useful. I changed the test following that, now in my branch ticket26007_029_02.

juga's branch ticket26007_029_02 looks good to me!

Trac:
Status: needs_review to merge_ready

Also merged to 029 and forward. Thanks!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

mentioned in issue #26155 (moved)

moved to tpo/core/tor#26007 (closed)